Remove MBEDTLS_MEMORY_BUFFER_ALLOC_C usages #190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove references to `MBEDTLS_MEMORY_BUFFER_ALLOC_C` as it is not used in Mbed OS, and Mbed OS has its own memory statistics mechanisms.
simonbutcher
suggested changes
Aug 1, 2018
benchmark/main.cpp
Outdated
| @@ -154,11 +150,6 @@ | |||
| */ | |||
| #define MEM_BLOCK_OVERHEAD ( 2 * sizeof( size_t ) ) | |||
There was a problem hiding this comment.
This line can also, and therefore should also be removed.
Remove the definitino of `MEM_BLOCK_OVERHEAD` as it is not needed anymore.
|
@sbutcher-arm I addressed your comment |
AndrzejKurek
approved these changes
Aug 2, 2018
|
Closing, as #194 covers this as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to
MBEDTLS_MEMORY_BUFFER_ALLOC_Cas it is not usedin Mbed OS, and Mbed OS has its own memory statistics mechanisms.
Resolves #171