Add Mbed trace support #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paul-szczepanek-arm Please review |
ghost
approved these changes
Jan 15, 2021
| @@ -95,8 +95,9 @@ def _input_thread(self): | |||
| log.warning('{}: Invalid bytes read: {}'.format(self.name, line)) | |||
| continue | |||
| plain_line.rstrip() | |||
There was a problem hiding this comment.
well, that looks like a nop
| @@ -25,7 +25,8 @@ | |||
| "target.printf_lib": "std", | |||
| "platform.stdio-flush-at-exit": false, | |||
| "platform.stdio-baud-rate": 115200, | |||
| "cordio.desired-att-mtu": 80 | |||
| "cordio.desired-att-mtu": 80, | |||
| "mbed-trace.enable": null | |||
Comment on lines
+189
to
+205
| mbed_trace_init(); | ||
| mbed_trace_prefix_function_set([](size_t) { | ||
| // This is the prefix added before any trace, the new line is used to | ||
| // ensure the trace is not rendered inside a line containing a json | ||
| // payload. The test tool filter out traces based on this pattern. | ||
| static char prefix[] = "\n~~~"; | ||
| return prefix; | ||
| }); | ||
| mbed_trace_print_function_set([](const char* str) { | ||
| get_serial().write(str, strlen(str)); | ||
| // Note: line return in mbed_trace somehow doesn't work if color support | ||
| // is deactivated. | ||
| get_serial().write("\n", 1); | ||
| }); | ||
| // Disable color support and carriage return support | ||
| mbed_trace_config_set(TRACE_ACTIVE_LEVEL_ALL); | ||
|
|
There was a problem hiding this comment.
shouldn't this be in #if MBED_CONF_MBED_TRACE_ENABLE
paul-szczepanek-arm
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mbed trace in ble-cliapp and the appropriate filters in the test runtime.
Please review, we can merge when the trace branch on Mbed OS has been merged.