Skip to content

Documentation updates for Toolchain changes #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SenRamakri
Copy link
Contributor

Documentation updates for Toolchain changes planned for 5.12 release

@SenRamakri
Copy link
Contributor Author

SenRamakri commented Feb 8, 2019

Please review - But DO NOT MERGE this until the compiler changes are done. We will update the comments in the PR once we are ready to merge this after tool chain work is done. I took a shortcut as of now to capture both IAR and ARMC changes in one PR. Its possible that one might happen but other might not, in that case we will update this PR accordingly. This covers - IOTCORE-825 and IOTCORE-709.

@deepikabhavnani
Copy link

Iar doc update PR was created long back - #885

In case one is updated can use that

@SenRamakri SenRamakri force-pushed the sen_CompilerUpdateDocs branch from f22e192 to 5416a23 Compare February 25, 2019 20:27
@SenRamakri
Copy link
Contributor Author

@AnotherButler @kegilbert - I added more changes to this PR as we changed our requirements around ARMC6 transition and that caused more documentation changes. Please review.

@AnotherButler
Copy link
Contributor

Does this still have a code dependency?

@AnotherButler
Copy link
Contributor

@SenRamakri Is this ready to merge, or are we waiting on a code dependency?

@SenRamakri
Copy link
Contributor Author

@SenRamakri Is this ready to merge, or are we waiting on a code dependency?

@AnotherButler - Unfortunately we need to wait, as IAR8 just merged today and we have to start on ARMC6 tomorrow. Sorry that we have to keep you waiting on this.

@AnotherButler
Copy link
Contributor

Could you please add a link here to the code PR?

@SenRamakri
Copy link
Contributor Author

SenRamakri commented Feb 27, 2019

@AnotherButler - Yes, actually we don't have a specific PR, we need the branch feature-armc6 merged before we can merge this documentation change. In fact, the merge PR is still not generated and Im waiting on this PR now - ARMmbed/mbed-os#9860, sorry for the convoluted info.
I'll update this PR once we are ready, Im assuming it might be end of tomorrow.

The `supported_toolchains` property is the list of toolchains that support a target. The allowed values for `supported_toolchains` are `ARM`, `uARM`, `ARMC6`, `GCC_ARM` and `IAR`.
The `supported_toolchains` property is the list of toolchains that support a target. The allowed values for `supported_toolchains` are `ARM`, `uARM`, `ARMC5`, `ARMC6`, `GCC_ARM` and `IAR`.

If you specify `ARMC5` in `supported_toolchains`, it means the corresponding target supports `Arm Compiler 5.06 update 6`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be explicit that any new targets should support ARMC6 not 5.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bulislaw - Please see the updates.

@deepikabhavnani
Copy link

Needs a rebase to resolve conflicts

@SenRamakri SenRamakri force-pushed the sen_CompilerUpdateDocs branch from d23347e to b0b086b Compare February 28, 2019 21:12
@SenRamakri
Copy link
Contributor Author

Rebased

Amanda Butler added 2 commits February 28, 2019 16:29
Edit note, mostly for branding and brevity.
Edit note, mostly for branding and active voice.
@AnotherButler
Copy link
Contributor

@bulislaw Have all of your concerns been addressed?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2019

Master received ARMC6 update. We are close to 5.12rc1, this documentation should be part of it.

@SenRamakri
Copy link
Contributor Author

@AnotherButler - ARMC6/IAR8 changes are merged to master. I think we are good to merge these changes now.

@AnotherButler
Copy link
Contributor

@bulislaw I'm going to merge this later today. If you have further concerns, please create a new PR.

@AnotherButler AnotherButler merged commit 3020126 into ARMmbed:development Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants