Skip to content

Enhance config system doc #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Enhance config system doc #931

merged 4 commits into from
Feb 1, 2019

Conversation

aashishc1988
Copy link
Contributor

Enhance config system documentation

@aashishc1988
Copy link
Contributor Author

@SenRamakri @kegilbert

Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, looks awesome thanks @aashishc1988 !

@aashishc1988
Copy link
Contributor Author

@kegilbert @SenRamakri @AnotherButler
Made recommended changes. Please review.

@aashishc1988
Copy link
Contributor Author

@SenRamakri @kegilbert
Ready for another review.

Edit file, mostly for branding and active voice.
}
```

If you use the example JSON snippet above, you can see the macro `MBED_CONF_CELLULAR_RANDOM_MAX_START_DELAY` in `mbed_config.h`. This macro is created for all targets and is set to `100`, whereas macro `MBED_CONF_PLATFORM_STDIO_BAUD_RATE` is set to `9600` only for the K64F. `mbed compile` places `mbed_config.h` in the build directory, and `mbed export` places it in the application root. `mbed compile` runs the Mbed configuration system before invoking the compiler, and `mbed export` runs the configuration system before creating project files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the bit about the K64F. We don't mention it before this line. Could you please clarify?

Copy link
Contributor Author

@aashishc1988 aashishc1988 Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if we take a look at the snippet, there are parameters that are defined under asterik (it is not letting me use that character here), and others that are defined for specific target (K64F in this case). The intent is to make sure that users understand the scope of a macro value based on the targets its defined for. Would it make the documentation clearer if I mention here that asterik is a wildcard that applies to all targets?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would, but only if our developers aren't expected to know that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are, then please ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That stuff is very basic, and it is mentioned later in this documentation.

@AnotherButler AnotherButler merged commit 25a077b into ARMmbed:development Feb 1, 2019
AnotherButler pushed a commit that referenced this pull request Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants