Skip to content

Allow overriding the ESP8266 timeouts #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Allow overriding the ESP8266 timeouts #40

merged 1 commit into from
Jul 26, 2017

Conversation

janjongboom
Copy link
Contributor

@janjongboom janjongboom commented Jul 26, 2017

By wrapping these in an #ifndef these can be overridden from user space (e.g. mbed_app.json). For a justification, see https://stackoverflow.com/questions/45328298/mbed-socket-connection-takes-a-long-time.

@geky @sarahmarshy

By wrapping these in an `#ifndef` these can be overridden from user space (e.g. mbed_app.json). For a justification, see https://stackoverflow.com/questions/45328298/mbed-socket-connection-takes-a-long-time.
@sarahmarshy
Copy link
Contributor

@janjongboom I don't see how this is related to ESP8266. The person in that thread is using ethernet...

@janjongboom
Copy link
Contributor Author

@sarahmarshy Ah, wow. Brain must have melted. Regardless, I think it's good to add these ifndef's.

@geky
Copy link
Contributor

geky commented Jul 26, 2017

This makes sense, we should probably also create an mbed_lib.json, but we can merge this for now

@geky geky merged commit 44fb447 into master Jul 26, 2017
@VeijoPesonen VeijoPesonen deleted the janjongboom-patch-1 branch August 22, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants