Separate interface from stack in ESP8266 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, although is this dependent on ARMmbed/mbed-os#151? Just wanting to note it that's the case |
|
Actually the opposite. I'll need this before 151 |
|
Oh, ok. Does this break compatibility with the current API? |
|
With a non-public network stack as it has now it does |
Create separate objects for the interface and stack of the ESP8266.
| /** Get the internally stored MAC address | ||
| * @return MAC address of the interface | ||
| */ | ||
| virtual const char *get_mac_address(); |
There was a problem hiding this comment.
Nit: const char* get_mac_address() for return types in this changeset
Move the asterisk so it is closer to the return type on several functions.
|
Actually, forgot the ESP got moved out of mbed-os. This PR can wait until after ARMmbed/mbed-os#151 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create separate objects for the interface and stack of the ESP8266.