Skip to content

Exercise enhancement q3 2023 - first 10 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 84 commits into from
Aug 23, 2023

Conversation

UmiKami
Copy link
Contributor

@UmiKami UmiKami commented Jul 27, 2023

No description provided.

```

En este ejemplo, `nombre` es la variable. Le estamos diciendo a la computadora: "Recuerda `nombre` y déjalo ser igual a `Daniel`". El nombre de tu variable puede ser casi cualquier cosa que quieras, pero debe comenzar con una letra o con el carácter de subrayado (`_`). Es bueno elegir un nombre que te ayude a recordar qué guardaste en la "caja".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambia esta explicacion, mejorala un poco


```py
name = "Daniel"
```

In this example, `name` is the variable. We're telling the computer: "Remember `name` and let it equal `Daniel`." The name for your variable can be almost anything you want, but it must start with a letter or the underscore character (`_`). It's good to choose a name that helps you remember what you stored in the "box".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haz el mismo cambio que en español

@@ -11,7 +11,7 @@
@pytest.mark.it("Create a variable named 'color' with the string value red")
def test_declare_variable():
result = app.color
assert result == "red"
assert "red" in result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejalo como estaba result == "red"

1. Establece valores para las variables `my_var1` y `my_var2` de forma que el código imprima `Hello World` en la consola.

- **Nota** : Ten en cuenta el uso de mayúsculas y minúsculas en tu valor y los espacios extra. Por ejemplo, "hello World " hará que la prueba falle porque tienes una 'h' en minúscula y un espacio al final.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agregalo como una hint, tal como se hace en los otros ejercicios

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quita esta nota porque el test se convertira en not case sensitive

1. Set the values for `my_var1` and `my_var2` so the code prints `Hello World` in the console.

- **Note**: Be mindful of the casing of your value and extra spaces. For instance, "hello World " will make the test fail because you have a lower case 'h' and space at the end.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agregalo como una hint, como se hace en los otros ejercicios

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quita esta nota porque el test se convertira en not case sensitive

@@ -20,12 +20,12 @@ def test_my_var2_exists():
@pytest.mark.it("Variable my_var1 value should be 'Hello'")
def test_my_var1_value():
from app import my_var1
assert my_var1 == "Hello"
assert "Hello" in my_var1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejalo como estaba por ser el valor de la variable lo que se chequea


@pytest.mark.it("Variable my_var2 value should be 'World'")
def test_my_var2_value():
from app import my_var2
assert my_var2 == "World"
assert "World" in my_var2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejalo como estaba por ser el valor de la variable lo que se chequea

assert "Hello World\n" in captured#add \n because the console jumps the line on every print
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hazlo not case sensitive

@@ -13,7 +13,7 @@ def test_html_document_exists():
def test_html_document_exists():
try:
from app import html_document
assert html_document == '<html><head><title></title></head><body></body></html>'
assert '<html><head><title></title></head><body></body></html>' in html_document
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejalo como estaba por ser el valor de la variable lo que se chequea

@alesanchezr alesanchezr merged commit 31fe53c into 4GeeksAcademy:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants