User Secret should contain connection string

[genofire]

• Type of issue? feature request

It would be nice, to have also an key with an psql connection string in it, so that this value could easy reuse in application or helm-charts.

affected function generateSingleUserSecret - code is here:

postgres-operator/pkg/cluster/k8sres.go

Lines 1814 to 1826 in 0ac5f58

	secret := v1.Secret{
	ObjectMeta: metav1.ObjectMeta{
	Name: c.credentialSecretName(username),
	Namespace: pgUser.Namespace,
	Labels: lbls,
	Annotations: c.annotationsSet(nil),
	},
	Type: v1.SecretTypeOpaque,
	Data: map[string][]byte{
	"username": []byte(pgUser.Name),
	"password": []byte(pgUser.Password),
	},
	}

secrets should contain best values (with tls if enabled and namespace in url)

[FxKu]

We use pgUI for that e.g. to print the JDBC connection string. But, I just realize that this is not part of the OS code base. The connection string also varies from language to language, right? Not sure, the K8s secret is really the right place for it.

[genofire]

there are two string types:

• key-value
• uri
  both could be in the secret

for generating the pgUI is nice, but i like to give the secrets an pod for using it (or an helmchart, or fluxcd).
sadly the most application like the complete string, not only a field for username or password.

[batazor]

I also like the idea of adding a ready-made URI like postgres://username:password@service.namespace/database to the secret

Most applications expect the URI format as input, this allows you to run applications with data taken directly from the secret

[kehralexander]

I've attempted to hastily implement something like this by modifying the code snippet presented above like so:

secret := v1.Secret{
		ObjectMeta: metav1.ObjectMeta{
			Name:        c.credentialSecretName(username),
			Namespace:   pgUser.Namespace,
			Labels:      lbls,
			Annotations: c.annotationsSet(nil),
		},
		Type: v1.SecretTypeOpaque,
		Data: map[string][]byte{
			"username": []byte(pgUser.Name),
			"password": []byte(pgUser.Password),
			"uri":      []byte("postgresql://" + username + ":" + pgUser.Password + "@" + c.Name),
		},
	}

But when I create a cluster the URI field in the secret is 0 bytes / empty...
That being said I'm five minutes old to Golang, so I don't really know what I'm doing.