Optimize

Author: uetchy

README.md

@@ -63,6 +63,12 @@ If you put Alfred settings to another location, you should run following lines
 $ rake link ALFRED_WORKFLOW_PATH=/path/to/Alfred.alfredpreferences/workflows
 ```
 
+You can find Alfred preferences path by `mdfind` command like this:
+
+```
+$ mdfind Alfred.alfredpreferences
+```
+
 ### Testing workflow
 ```
 $ bundle install

commands/my.rb

@@ -8,9 +8,11 @@
 begin
   config = Qiita::Config.new
 rescue Qiita::FileMissingError
+  # Create empty config file if it doesn't exist
   config.save
 end
 
+# 'my' command needs Qiita API Token
 unless config.token
   Qiita::Alfred.message "RUN: 'qiita setup' command first"
   exit
@@ -19,19 +21,6 @@
 data = Qiita::API.get(:items, :token => config.token)
 data.select!{|a| a['title'].scan(QUERY).size > 0 } if QUERY
 
-results = []
-data.each do |q|
-  subtitle = q['stock_count'].to_s + " Stocks, " + q['comment_count'].to_s + " Comments, " + Time.parse(q['created_at']).strftime("%Y/%m/%d %H:%M:%S") + " Created"
-
-  item = {
-    :uid => nil,
-    :arg => q['url'],
-    :title => q['title'],
-    :subtitle => subtitle,
-    :icon => 'icon.png'
-  }
-
-  results << item
-end
+results = Qiita::Alfred.messages(data)
 
 puts Qiita::Alfred.to_alfred(results)

commands/search.rb

@@ -8,19 +8,6 @@
 data = Qiita::API.search(QUERY)
 data.sort! {|a, b| b['stock_count'] <=> a['stock_count'] }
 
-results = []
-data.each do |q|
-  arg = q['url']
-  subtitle = q['stock_count'].to_s + " Stocks, " + q['comment_count'].to_s + " Comments, " + Time.parse(q['created_at']).strftime("%Y/%m/%d %H:%M:%S") + " Created"
-
-  item = {
-    :uid => nil,
-    :arg => arg,
-    :title => q['title'],
-    :subtitle => subtitle,
-    :icon => 'icon.png'
-  }
-  results << item
-end
+results = Qiita::Alfred.messages(data)
 
 puts Qiita::Alfred.to_alfred(results)

commands/stocks.rb

@@ -11,6 +11,7 @@
   config.save
 end
 
+# 'stocks' command needs Qiita API Token
 unless config.token
   Qiita::Alfred.message "RUN: 'qiita setup' command first"
   exit
@@ -19,19 +20,6 @@
 data = !QUERY.empty? ? Qiita::API.search(QUERY, :token => config.token, :stocked => 1) : Qiita::API.get(:stocks, :token => config.token)
 data.sort! {|a, b| b['stock_count'] <=> a['stock_count'] }
 
-results = []
-data.each do |q|
-  subtitle = q['stock_count'].to_s + " Stocks, " + q['comment_count'].to_s + " Comments, " + Time.parse(q['created_at']).strftime("%Y/%m/%d %H:%M:%S") + " Created"
-
-  item = {
-    :uid => nil,
-    :arg => q['url'],
-    :title => q['title'],
-    :subtitle => subtitle,
-    :icon => 'icon.png'
-  }
-
-  results << item
-end
+results = Qiita::Alfred.messages(data)
 
 puts Qiita::Alfred.to_alfred(results)

lib/qiita/alfred.rb

@@ -26,6 +26,25 @@ def self.to_alfred(array)
       doc.to_s
     end
 
+    def self.messages(texts_array)
+      results = []
+      texts_array.each do |q|
+        subtitle = q['stock_count'].to_s + " Stocks, " + q['comment_count'].to_s + " Comments, " + Time.parse(q['created_at']).strftime("%Y/%m/%d %H:%M:%S") + " Created"
+
+        item = {
+          :uid => nil,
+          :arg => q['url'],
+          :title => q['title'],
+          :subtitle => subtitle,
+          :icon => 'icon.png'
+        }
+
+        results << item
+      end
+
+      return results
+    end
+
     def self.message(str)
       puts Qiita::Alfred.to_alfred([{
         :uid => 0,