Add after_script

[dkrikun]

Please add after_script mirroring the before_script functionality, but on tear-down

[tony]

@dkrikun Would be happy to accept a PR.

Is there a hook in tmux to run something when a session/window/pane closes?

[dkrikun]

No idea :)

…

On Sun, Dec 1, 2019, 21:42 Tony Narlock ***@***.***> wrote: @dkrikun <https://github.com/dkrikun> Would be happy to accept a PR. Is there a hook in tmux to run something when a session/window/pane closes? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#516?email_source=notifications&email_token=AAD4MBEC3BZJR4M76FXPWOTQWQHTXA5CNFSM4JTK2CL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFRTOLQ#issuecomment-560150318>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD4MBGOI2BRHBXIBUENF5LQWQHTXANCNFSM4JTK2CLQ> .

[joseph-flinn]

Looks like there is a session-closed tmux hook and may be an after-session-close hook that could be used to add the after_script feature

[tony]

@joseph-flinn Those seem like worth a try. Do we wanna do that here or in a follow up PR?

[joseph-flinn]

@tony If we are planning on dropping Python 2 support in the same release as the plugin system, it might be a good idea to get the after_script feature in before/with the plugin-system so that we could add in an after_script feature to the plugin-system. Whether a PR is before/with/after the plugin system PR, I think it would be a good idea to support Python 2 until the after_script feature is added.

[tony]

@joseph-flinn Here is what I propose:

• I will cut a release for 1.6.0 (for tmuxp shell, whatever else we merge since 1.5.8), now / tomorrow AM
• Tomorrow we merge this - with or without the after_script thing and then release 1.7.0a1 (tagged v1.7.0a1, so its on PyPI and in master
• We can set plugins locally in our tmuxp and play around w/ it, and also tweak the plugin system and release alpha releases
• Make a PR to add after_script, and the CLI logging tool
• Release 1.7.0 final
• Any commits after v1.7.0 have no python 2.7 support
• Remove Python 2.7 support in master 1.8.0

Thoughts?

[joseph-flinn]

Yep, that sound like a good plan!

…

On Fri, Nov 6, 2020, 17:49 Tony Narlock ***@***.***> wrote: @joseph-flinn <https://github.com/joseph-flinn> Here is what I propose: - I will cut a release for 1.6.0 (for tmuxp shell), now / tomorrow AM - Tomorrow we merge this - with or without that after_script thing and then release 1.7.0a1, so its on PyPI and in master - We can set plugins locally in our tmuxp and play around w/ it, and also tweak the plugin system and release alpha releases - Make a PR to add after_script, and the CLI logging tool - Release 1.7.0 final - Remove Python 2.7 support in master 1.8.0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN5KNNO7OCTHLXRHYETPPFLSOSRQ7ANCNFSM4JTK2CLQ> .