This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: set backfill to failed if the job running it will be failed #50569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to the two backfilling job handlers to see if the current failure will be cause the job to fail, and if so it sets the backfill to failed.
I don't really like this but currently I don't see another way aside from a PostHandler that looked queried the job after every run to check the state
closes https://github.com/sourcegraph/sourcegraph/issues/50532
Test plan
Added unit test for new handler
Created insights with repo search that yields no repo causing failure.