Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[SG-45991] Disable package hoisting #46080

Closed
wants to merge 77 commits into from

Conversation

gitstart-sourcegraph
Copy link
Collaborator

@gitstart-sourcegraph gitstart-sourcegraph commented Jan 3, 2023

Description

  • lift other dependencies from the root package.json to client workspaces packages and disable package hoisting in the .npmrc

Refs

SourceGraph Issue
GitStart ticket

App preview:

Check out the client app preview documentation to learn more.

@gitstart-sourcegraph gitstart-sourcegraph added the gitstart Contract partner label Jan 3, 2023
@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Jan 3, 2023
@cla-bot cla-bot bot added the cla-signed label Jan 3, 2023
@gitstart-sourcegraph gitstart-sourcegraph changed the base branch from main to vb/pnpm-test-2 January 3, 2023 16:00
@gitstart-sourcegraph gitstart-sourcegraph changed the base branch from vb/pnpm-test-2 to contractors/pnpm-fix-1 January 3, 2023 16:00
@gitstart-sourcegraph gitstart-sourcegraph changed the base branch from contractors/pnpm-fix-1 to vb/pnpm-test-2 January 3, 2023 16:02
@gitstart-sourcegraph
Copy link
Collaborator Author

@valerybugakov could you please take a look at this spec PR? We traced all import and require to know which modules are used in a package. WDYT if we follow this https://pnpm.io/blog/2020/10/17/node-modules-configuration-options-with-pnpm#plugnplay-the-strictest-configuration to enable PnP?

@valerybugakov
Copy link
Member

@gitstart-sourcegraph, thank you! The spec looks excellent.

Let's first focus on completing the pnpm migration https://github.com/sourcegraph/sourcegraph/pull/46008. The key objective is to make the CI green. Then, we can test this PR properly, relying on CI checks. And after that, we think about enabling PnP in a follow-up PR.

@github-actions
Copy link
Contributor

Problem: the label i-acknowledge-this-goes-into-the-release is absent.
👉 What to do: we're in the next Sourcegraph release code freeze period. If you are 100% sure your changes should get released or provide no risk to the release, add the label your PR with i-acknowledge-this-goes-into-the-release.

@github-actions
Copy link
Contributor

Problem: the label i-acknowledge-this-goes-into-the-release is absent.
👉 What to do: we're in the next Sourcegraph release code freeze period. If you are 100% sure your changes should get released or provide no risk to the release, add the label your PR with i-acknowledge-this-goes-into-the-release.

@sg-e2e-regression-test-bob
Copy link

sg-e2e-regression-test-bob commented Jan 17, 2023

Bundle size report 📦

Initial size Total size Async size Modules
2.98% (+84.01 kb) 🔺 0.73% (+105.79 kb) 🔺 0.19% (+21.78 kb) 🔺 0.28% (+2) 🔺

Look at the Statoscope report for a full comparison between the commits 119a400 and f42c059 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@gitstart-sourcegraph gitstart-sourcegraph marked this pull request as ready for review January 27, 2023 03:59
@gitstart-sourcegraph
Copy link
Collaborator Author

@valerybugakov We fixed errors on contractors pipeline. Could you please review and give us the errors on other pipelines?

@gitstart-sourcegraph
Copy link
Collaborator Author

Closing this based on it's interference with the Bezel migration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable package hoisting
3 participants