Skip to content

RedundantPredicateMatcher is not a safe autocorrect #2012

Open
@luke-hill

Description

@luke-hill

Expected behavior

When using RSpec with autocorrect I assumed it wouldn't break my codebase

Actual behavior

In cucumber-ruby-core it replaced be_match with match. However these weren't correct, because the codebase had defined match? as a method. So the correct behaviour here is to detect that the method match? has been defined, and then not suggest an autocorrect or error here.

Steps to reproduce the problem

cucumber/cucumber-ruby-core@release/v13.0.3...main#diff-146e0d9fad5351a0fc7a77b7bb4e47a19b46a83e67e03c9330cd294077be02abL65)

RuboCop RSpec version

RuboCop version incompatibility found, RuboCop server restarting...
RuboCop server starting on 127.0.0.1:36575.
1.69.2 (using Parser 3.3.6.0, rubocop-ast 1.37.0, analyzing as Ruby 3.0, running on ruby 3.1.6) +server [x86_64-linux]
  - rubocop-packaging 0.5.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 3.0.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions