Update language-client to 8.1.0 (#2377)

Signed-off-by: Shi Chen <chenshi@microsoft.com>

Author: CsCherrYY

package-lock.json

@@ -1397,7 +1397,7 @@
     "@types/glob": "5.0.30",
     "@types/lodash.findindex": "^4.6.6",
     "@types/mocha": "^5.2.5",
-    "@types/node": "^8.10.51",
+    "@types/node": "^16.11.7",
     "@types/semver": "^7.3.8",
     "@types/sinon": "^10.0.12",
     "@types/vscode": "^1.74.0",
@@ -1418,7 +1418,7 @@
     "request": "^2.88.2",
     "sinon": "^14.0.0",
     "ts-loader": "^9.2.6",
-    "typescript": "^4.2.4",
+    "typescript": "^4.6.4",
     "webpack": "^5.28.0",
     "webpack-cli": "^4.6.0"
   },
@@ -1431,7 +1431,7 @@
     "htmlparser2": "6.0.1",
     "jdk-utils": "^0.4.4",
     "semver": "^7.3.5",
-    "vscode-languageclient": "7.1.0-next.5",
+    "vscode-languageclient": "8.1.0",
     "winreg-utf8": "^0.1.1",
     "winston": "^3.2.1",
     "winston-daily-rotate-file": "^3.10.0"

package.json

@@ -1,5 +1,5 @@
 import { window, commands } from "vscode";
-import { ErrorHandler, Message, ErrorAction, CloseAction } from "vscode-languageclient";
+import { ErrorHandler, Message, ErrorAction, CloseAction, ErrorHandlerResult, CloseHandlerResult } from "vscode-languageclient";
 import { Commands } from "./commands";
 import { logger } from "./log";
 
@@ -10,21 +10,27 @@ export class ClientErrorHandler implements ErrorHandler {
 		this.restarts = [];
 	}
 
-	public error(_error: Error, _message: Message, count: number): ErrorAction {
+	public error(_error: Error, _message: Message, count: number): ErrorHandlerResult {
 		if (count && count <= 3) {
 			logger.error(`${this.name} server encountered error: ${_message}, ${_error && _error.toString()}`);
-			return ErrorAction.Continue;
+			return {
+				action: ErrorAction.Continue
+			};
 		}
 
 		logger.error(`${this.name} server encountered error and will shut down: ${_message}, ${_error && _error.toString()}`);
-		return ErrorAction.Shutdown;
+		return {
+			action: ErrorAction.Shutdown
+		};
 	}
 
-	public closed(): CloseAction {
+	public closed(): CloseHandlerResult {
 		this.restarts.push(Date.now());
 		if (this.restarts.length < 5) {
 			logger.error(`The ${this.name} server crashed and will restart.`);
-			return CloseAction.Restart;
+			return {
+				action: CloseAction.Restart
+			};
 		} else {
 			const diff = this.restarts[this.restarts.length - 1] - this.restarts[0];
 			if (diff <= 3 * 60 * 1000) {
@@ -36,12 +42,16 @@ export class ClientErrorHandler implements ErrorHandler {
 						commands.executeCommand(Commands.OPEN_LOGS);
 					}
 				});
-				return CloseAction.DoNotRestart;
+				return {
+					action: CloseAction.DoNotRestart
+				};
 			}
 
 			logger.error(`The ${this.name} server crashed and will restart.`);
 			this.restarts.shift();
-			return CloseAction.Restart;
+			return {
+				action: CloseAction.Restart
+			};
 		}
 	}
 }

src/clientErrorHandler.ts

@@ -6,7 +6,7 @@ import * as fse from 'fs-extra';
 import * as os from 'os';
 import * as path from 'path';
 import { CodeActionContext, CodeActionTriggerKind, commands, ConfigurationTarget, Diagnostic, env, EventEmitter, ExtensionContext, extensions, IndentAction, InputBoxOptions, languages, RelativePattern, TextDocument, UIKind, Uri, ViewColumn, window, workspace, WorkspaceConfiguration } from 'vscode';
-import { CancellationToken, CodeActionParams, CodeActionRequest, Command, DidChangeConfigurationNotification, ExecuteCommandParams, ExecuteCommandRequest, LanguageClientOptions, RevealOutputChannelOn } from 'vscode-languageclient';
+import { CancellationToken, CodeActionParams, CodeActionRequest, Command, DidChangeConfigurationNotification, ExecuteCommandParams, ExecuteCommandRequest, LanguageClientOptions, RevealOutputChannelOn, State } from 'vscode-languageclient';
 import { LanguageClient } from 'vscode-languageclient/node';
 import { apiManager } from './apiManager';
 import { ClientErrorHandler } from './clientErrorHandler';
@@ -167,16 +167,15 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 						resolveAdditionalTextEditsSupport: true,
 						advancedIntroduceParameterRefactoringSupport: true,
 						actionableRuntimeNotificationSupport: true,
-						shouldLanguageServerExitOnShutdown: true,
 						onCompletionItemSelectedCommand: "editor.action.triggerParameterHints",
 						extractInterfaceSupport: true,
 					},
 					triggerFiles,
 				},
 				middleware: {
 					workspace: {
-						didChangeConfiguration: () => {
-							standardClient.getClient().sendNotification(DidChangeConfigurationNotification.type, {
+						didChangeConfiguration: async () => {
+							await standardClient.getClient().sendNotification(DidChangeConfigurationNotification.type, {
 								settings: {
 									java: getJavaConfig(requirements.java_home),
 								}
@@ -185,12 +184,12 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 					},
 					// https://github.com/redhat-developer/vscode-java/issues/2130
 					// include all diagnostics for the current line in the CodeActionContext params for the performance reason
-					provideCodeActions: (document, range, context, token, next) => {
+					provideCodeActions: async (document, range, context, token, next) => {
 						const client: LanguageClient = standardClient.getClient();
 						const params: CodeActionParams = {
 							textDocument: client.code2ProtocolConverter.asTextDocumentIdentifier(document),
 							range: client.code2ProtocolConverter.asRange(range),
-							context: client.code2ProtocolConverter.asCodeActionContext(context)
+							context: await client.code2ProtocolConverter.asCodeActionContext(context)
 						};
 						const showAt  = getJavaConfiguration().get<string>("quickfix.showAt");
 						if (showAt === 'line' && range.start.line === range.end.line && range.start.character === range.end.character) {
@@ -209,12 +208,12 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 								const codeActionContext: CodeActionContext = {
 									diagnostics: allDiagnostics,
 									only: context.only,
-									triggerKind: CodeActionTriggerKind.Invoke,
+									triggerKind: context.triggerKind,
 								};
-								params.context = client.code2ProtocolConverter.asCodeActionContext(codeActionContext);
+								params.context = await client.code2ProtocolConverter.asCodeActionContext(codeActionContext);
 							}
 						}
-						return client.sendRequest(CodeActionRequest.type, params, token).then((values) => {
+						return client.sendRequest(CodeActionRequest.type, params, token).then(async (values) => {
 							if (values === null) {
 								return undefined;
 							}
@@ -224,7 +223,7 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 									result.push(client.protocol2CodeConverter.asCommand(item));
 								}
 								else {
-									result.push(client.protocol2CodeConverter.asCodeAction(item));
+									result.push(await client.protocol2CodeConverter.asCodeAction(item));
 								}
 							}
 							return result;
@@ -249,13 +248,16 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 			// no need to pass `resolve` into any code past this point,
 			// since `resolve` is a no-op from now on
 
+			const serverOptions = prepareExecutable(requirements, syntaxServerWorkspacePath, getJavaConfig(requirements.java_home), context, true);
 			if (requireSyntaxServer) {
 				if (process.env['SYNTAXLS_CLIENT_PORT']) {
 					syntaxClient.initialize(requirements, clientOptions);
 				} else {
-					syntaxClient.initialize(requirements, clientOptions, prepareExecutable(requirements, syntaxServerWorkspacePath, getJavaConfig(requirements.java_home), context, true));
+					syntaxClient.initialize(requirements, clientOptions, serverOptions);
 				}
-				syntaxClient.start();
+				syntaxClient.start().then(() => {
+					syntaxClient.registerSyntaxClientActions(serverOptions);
+				});
 				serverStatusBarProvider.showLightWeightStatus();
 			}
 
@@ -430,7 +432,9 @@ async function startStandardServer(context: ExtensionContext, requirements: requ
 		apiManager.fireDidServerModeChange(ServerMode.hybrid);
 	}
 	await standardClient.initialize(context, requirements, clientOptions, workspacePath, jdtEventEmitter);
-	standardClient.start();
+	standardClient.start().then(async () => {
+		standardClient.registerLanguageClientActions(context, await fse.pathExists(path.join(workspacePath, ".metadata", ".plugins")), jdtEventEmitter);
+	});
 	serverStatusBarProvider.showStandardStatus();
 }
 
@@ -532,7 +536,9 @@ export async function getActiveLanguageClient(): Promise<LanguageClient | undefi
 		return undefined;
 	}
 
-	await languageClient.onReady();
+	if (languageClient.needsStart()) {
+		await languageClient.start();
+	}
 
 	return languageClient;
 }

src/extension.ts

@@ -165,7 +165,7 @@ function getWillRenameHandler(client: LanguageClient) {
                 const edit = await client.sendRequest(WillRenameFiles.type, {
                     files: javaRenameEvents
                 });
-                resolve(client.protocol2CodeConverter.asWorkspaceEdit(edit));
+                resolve(await client.protocol2CodeConverter.asWorkspaceEdit(edit));
             } catch (ex) {
                 reject(ex);
             }

src/fileEventHandler.ts

@@ -94,7 +94,7 @@ class PasteEditProvider implements DocumentPasteEditProvider {
 			if (pasteResponse) {
 				return {
 					insertText: pasteResponse.insertText,
-					additionalEdit: pasteResponse.additionalEdit ? this.languageClient.protocol2CodeConverter.asWorkspaceEdit(pasteResponse.additionalEdit) : undefined
+					additionalEdit: pasteResponse.additionalEdit ? await this.languageClient.protocol2CodeConverter.asWorkspaceEdit(pasteResponse.additionalEdit) : undefined
 				} as VDocumentPasteEdit;
 			}
 		} catch (e) {

src/pasteEventHandler.ts

@@ -226,7 +226,7 @@ async function applyRefactorEdit(languageClient: LanguageClient, refactorEdit: R
     }
 
     if (refactorEdit.edit) {
-        const edit = languageClient.protocol2CodeConverter.asWorkspaceEdit(refactorEdit.edit);
+        const edit = await languageClient.protocol2CodeConverter.asWorkspaceEdit(refactorEdit.edit);
         if (edit) {
             await workspace.applyEdit(edit);
         }

src/refactorAction.ts

@@ -385,7 +385,7 @@ function registerGenerateDelegateMethodsCommand(languageClient: LanguageClient,
 }
 
 async function revealWorkspaceEdit(workspaceEdit: WorkspaceEdit, languageClient: LanguageClient): Promise<void> {
-    const codeWorkspaceEdit = languageClient.protocol2CodeConverter.asWorkspaceEdit(workspaceEdit);
+    const codeWorkspaceEdit = await languageClient.protocol2CodeConverter.asWorkspaceEdit(workspaceEdit);
     if (!codeWorkspaceEdit) {
         return;
     }