mysqlcluster: when storage size shrink, and change replicas, It will reconcile fail forever. #436

Author: acekingke

mysqlcluster/syncer/statefulset.go

@@ -167,7 +167,10 @@ func (s *StatefulSetSyncer) canExpandPVC(ctx context.Context) bool {
 	// If newStorage is not greater than oldStorage, do not expand.
 	if newStorage.Cmp(*oldRequest.Storage()) != 1 {
 		log.Info("canExpandPVC", "result", "can not expand", "reason", "new pvc is not larger than old pvc")
-		return false
+		// Should return true, because if change replicas and storage size, it will fail again and again
+		// during expanding PVCs, not great then oldStorage it will not truely expand, just recreate
+		// statefulset.
+		return true
 	}
 	return true
 }