Fix tests/var_dump.phpt

stesie · stesie · commit 670554306a3c · 2015-11-28T15:27:35.000+01:00
Recent V8 versions (e.g. 4.8.253 or 4.9.19) consider
`IsFunction() = true` for Closure objects from PHP; but earlier
versions didn't.

This ensures consistent var_dump behaviour (sticking to the
behaviour with older V8 versions).
diff --git a/v8js_methods.cc b/v8js_methods.cc
@@ -138,7 +138,7 @@ static void v8js_dumper(v8::Isolate *isolate, v8::Local<v8::Value> var, int leve
 		V8JS_GET_CLASS_NAME(cname, object);
 		int hash = object->GetIdentityHash();
 
-		if (var->IsFunction())
+		if (var->IsFunction() && strcmp(ToCString(cname), "Closure") != 0)
 		{
 			v8::String::Utf8Value csource(object->ToString());
 			php_printf("object(Closure)#%d {\n%*c%s\n", hash, level * 2 + 2, ' ', ToCString(csource));

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ static void v8js_dumper(v8::Isolate *isolate, v8::Local<v8::Value> var, int leve`
`138`	`138`	`V8JS_GET_CLASS_NAME(cname, object);`
`139`	`139`	`int hash = object->GetIdentityHash();`
`140`	`140`
`141`		`- if (var->IsFunction())`
	`141`	`+ if (var->IsFunction() && strcmp(ToCString(cname), "Closure") != 0)`
`142`	`142`	`{`
`143`	`143`	`v8::String::Utf8Value csource(object->ToString());`
`144`	`144`	`php_printf("object(Closure)#%d {\n%c%s\n", hash, level 2 + 2, ' ', ToCString(csource));`