Skip to content

Commit 4853c6d

Browse files
committed
Set script identifier as String, not Symbol
Otherwise long module identifiers might get cut off.
1 parent bf58fe6 commit 4853c6d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

v8js_methods.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ V8JS_METHOD(require)
347347
// Enter the module context
348348
v8::Context::Scope scope(context);
349349
// Set script identifier
350-
v8::Local<v8::String> sname = V8JS_SYM(normalised_module_id);
350+
v8::Local<v8::String> sname = V8JS_STR(normalised_module_id);
351351

352352
v8::Local<v8::String> source = V8JS_STRL(Z_STRVAL_P(module_code), Z_STRLEN_P(module_code));
353353
zval_ptr_dtor(&module_code);

0 commit comments

Comments
 (0)