Skip to content

Commit 37ffdc6

Browse files
authored
Merge pull request #303 from stesie/issue-302
Fixes test on V8 5.9.35
2 parents cc1e140 + 54e3a07 commit 37ffdc6

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

Commandfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,11 @@ command 'build',
3131

3232
command 'test',
3333
description: 'executes "make test"',
34+
parameters: {
35+
tests: { wrap: "TESTS=tests/%s", optional: true },
36+
},
3437
script: <<-eof
35-
cd /data/build; `which gmake || which make` test NO_INTERACTION=1 REPORT_EXIT_STATUS=1
38+
cd /data/build; `which gmake || which make` test %{tests} NO_INTERACTION=1 REPORT_EXIT_STATUS=1
3639
eof
3740

3841
command 'shell',

tests/exception_start_column.phpt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,23 @@ Test V8::executeString() : Test getJsStartColumn on script exception
66
<?php
77
$v8 = new V8Js();
88

9+
// V8 started to return different start column numbers,
10+
// hence let's do two errors and just look at the offset
11+
912
try {
1013
$v8->executeString("print(blar());");
1114
}
12-
catch(V8JsScriptException $e) {
13-
var_dump($e->getJsStartColumn());
15+
catch(V8JsScriptException $a) { }
16+
17+
try {
18+
$v8->executeString("(null); print(blar());");
1419
}
20+
catch(V8JsScriptException $b) { }
21+
22+
var_dump($b->getJsStartColumn() - $a->getJsStartColumn());
1523

1624
?>
1725
===EOF===
1826
--EXPECT--
19-
int(6)
27+
int(8)
2028
===EOF===

0 commit comments

Comments
 (0)