Added tests for ManyToOne relations

Author: lookyman

tests/Rules/Doctrine/ORM/EntityRelationRuleTest.php

@@ -27,8 +27,28 @@ public function testRule(string $file, array $expectedErrors): void
 
 	public function ruleProvider(): Iterator
 	{
-		yield [__DIR__ . '/data/EntityWithRelations.php', []];
-		yield [__DIR__ . '/data/EntityWithBrokenOneToOneRelations.php', [
+		yield 'nice entity' => [__DIR__ . '/data/EntityWithRelations.php', []];
+
+		yield 'one to one' => [__DIR__ . '/data/EntityWithBrokenOneToOneRelations.php', [
+			[
+				'Property can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but database expects PHPStan\Rules\Doctrine\ORM\AnotherEntity.',
+				31,
+			],
+			[
+				'Database can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but property expects PHPStan\Rules\Doctrine\ORM\AnotherEntity.',
+				37,
+			],
+			[
+				'Database can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but property expects PHPStan\Rules\Doctrine\ORM\MyEntity|null.',
+				50,
+			],
+			[
+				'Property can contain PHPStan\Rules\Doctrine\ORM\MyEntity|null but database expects PHPStan\Rules\Doctrine\ORM\AnotherEntity|null.',
+				50,
+			]
+		]];
+
+		yield 'many to one' => [__DIR__ . '/data/EntityWithBrokenManyToOneRelations.php', [
 			[
 				'Property can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but database expects PHPStan\Rules\Doctrine\ORM\AnotherEntity.',
 				31,

tests/Rules/Doctrine/ORM/data/EntityWithBrokenManyToOneRelations.php

@@ -0,0 +1,52 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class EntityWithBrokenManyToOneRelations
+{
+
+	/**
+	 * @ORM\Id()
+	 * @ORM\Column(type="int")
+	 * @var int
+	 */
+	private $id;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity|null
+	 */
+	private $manyToOneNullableBoth;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @ORM\JoinColumn(nullable=false)
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity|null
+	 */
+	private $manyToOneNullableProperty;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity
+	 */
+	private $manyToOneNullableColumn;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @ORM\JoinColumn(nullable=false)
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity
+	 */
+	private $manyToOneNonNullable;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\MyEntity|null
+	 */
+	private $manyToOneWrongClass;
+
+}