Fixing risky tests

Makring tests that have no assertions with the annotation to suppress
phpunits warning around risky tests

closes 1370

Author: JimTools

Tests/ArrayProcessorRegistryTest.php

@@ -18,6 +18,9 @@ public function testShouldImplementProcessorRegistryInterface()
         $this->assertClassImplements(ProcessorRegistryInterface::class, ArrayProcessorRegistry::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArgument()
     {
         new ArrayProcessorRegistry();

Tests/Client/ChainExtensionTest.php

@@ -29,6 +29,9 @@ public function testShouldBeFinal()
         $this->assertClassFinal(ChainExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExtensionsArray()
     {
         new ChainExtension([$this->createExtension(), $this->createExtension()]);

Tests/Client/ConsumptionExtension/DelayRedeliveredMessageExtensionTest.php

@@ -23,6 +23,9 @@
 
 class DelayRedeliveredMessageExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DelayRedeliveredMessageExtension($this->createDriverMock(), 12345);

Tests/Client/ConsumptionExtension/ExclusiveCommandExtensionTest.php

@@ -34,6 +34,9 @@ public function testShouldBeFinal()
         $this->assertClassFinal(ExclusiveCommandExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithDriverAsFirstArgument()
     {
         new ExclusiveCommandExtension($this->createDriverStub());

Tests/Client/ConsumptionExtension/FlushSpoolProducerExtensionTest.php

@@ -30,6 +30,9 @@ public function testShouldImplementEndExtensionInterface()
         $this->assertClassImplements(EndExtensionInterface::class, FlushSpoolProducerExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithSpoolProducerAsFirstArgument()
     {
         new FlushSpoolProducerExtension($this->createSpoolProducerMock());

Tests/Client/ConsumptionExtension/LogExtensionTest.php

@@ -55,6 +55,9 @@ public function testShouldSubClassOfLogExtension()
         $this->assertClassExtends(\Enqueue\Consumption\Extension\LogExtension::class, LogExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new LogExtension();

Tests/Client/ConsumptionExtension/SetRouterPropertiesExtensionTest.php

@@ -27,6 +27,9 @@ public function testShouldImplementMessageReceivedExtensionInterface()
         $this->assertClassImplements(MessageReceivedExtensionInterface::class, SetRouterPropertiesExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new SetRouterPropertiesExtension($this->createDriverMock());

Tests/Client/ConsumptionExtension/SetupBrokerExtensionTest.php

@@ -21,6 +21,9 @@ public function testShouldImplementStartExtensionInterface()
         $this->assertClassImplements(StartExtensionInterface::class, SetupBrokerExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new SetupBrokerExtension($this->createDriverMock());

Tests/Client/DelegateProcessorTest.php

@@ -13,6 +13,9 @@
 
 class DelegateProcessorTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DelegateProcessor($this->createProcessorRegistryMock());

Tests/Client/DriverFactoryTest.php

@@ -61,6 +61,9 @@ public function testShouldBeFinal()
         $this->assertTrue($rc->isFinal());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new DriverFactory();

Tests/Client/DriverPreSendTest.php

@@ -19,6 +19,9 @@ public function testShouldBeFinal()
         self::assertClassFinal(DriverPreSend::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExpectedArguments()
     {
         new DriverPreSend(

Tests/Client/Extension/PrepareBodyExtensionTest.php

@@ -22,6 +22,9 @@ public function testShouldImplementExtensionInterface()
         $this->assertTrue($rc->implementsInterface(PreSendCommandExtensionInterface::class));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldConstructedWithoutAnyArguments()
     {
         new PrepareBodyExtension();

Tests/Client/PostSendTest.php

@@ -21,6 +21,9 @@ public function testShouldBeFinal()
         self::assertClassFinal(PostSend::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExpectedArguments()
     {
         new PostSend(

Tests/Client/PreSendTest.php

@@ -18,6 +18,9 @@ public function testShouldBeFinal()
         self::assertClassFinal(PreSend::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExpectedArguments()
     {
         new PreSend(

Tests/Client/ProducerTest.php

@@ -24,11 +24,17 @@ public function testShouldBeFinal()
         self::assertClassFinal(Producer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new Producer($this->createDriverMock(), $this->createRpcFactoryMock());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithOptionalArguments()
     {
         new Producer(

Tests/Client/SpoolProducerTest.php

@@ -18,6 +18,9 @@ public function testShouldImplementProducerInterface()
         self::assertClassImplements(ProducerInterface::class, SpoolProducer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRealProducer()
     {
         new SpoolProducer($this->createProducerMock());

Tests/Client/TraceableProducerTest.php

@@ -18,6 +18,9 @@ public function testShouldImplementProducerInterface()
         $this->assertClassImplements(ProducerInterface::class, TraceableProducer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithInternalMessageProducer()
     {
         new TraceableProducer($this->createProducerMock());

Tests/ConnectionFactoryFactoryTest.php

@@ -37,18 +37,27 @@ public function testShouldBeFinal()
         $this->assertTrue($rc->isFinal());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new ConnectionFactoryFactory();
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testShouldAcceptStringDSN()
     {
         $factory = new ConnectionFactoryFactory();
 
         $factory->create('null:');
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testShouldAcceptArrayWithDsnKey()
     {
         $factory = new ConnectionFactoryFactory();

Tests/Consumption/CallbackProcessorTest.php

@@ -18,6 +18,9 @@ public function testShouldImplementProcessorInterface()
         $this->assertClassImplements(Processor::class, CallbackProcessor::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithCallableAsArgument()
     {
         new CallbackProcessor(function () {

Tests/Consumption/ChainExtensionTest.php

@@ -33,6 +33,9 @@ public function testShouldImplementExtensionInterface()
         $this->assertClassImplements(ExtensionInterface::class, ChainExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExtensionsArray()
     {
         new ChainExtension([$this->createExtension(), $this->createExtension()]);

Tests/Consumption/Exception/IllegalContextModificationExceptionTest.php

@@ -21,6 +21,9 @@ public function testShouldExtendLogicException()
         $this->assertClassExtends(\LogicException::class, IllegalContextModificationException::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new IllegalContextModificationException();

Tests/Consumption/Exception/InvalidArgumentExceptionTest.php

@@ -21,6 +21,9 @@ public function testShouldExtendLogicException()
         $this->assertClassExtends(\LogicException::class, InvalidArgumentException::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new InvalidArgumentException();
@@ -36,6 +39,9 @@ public function testThrowIfAssertInstanceOfNotSameAsExpected()
         InvalidArgumentException::assertInstanceOf(new \SplStack(), \SplQueue::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testShouldDoNothingIfAssertDestinationInstanceOfSameAsExpected()
     {
         InvalidArgumentException::assertInstanceOf(new \SplQueue(), \SplQueue::class);

Tests/Consumption/Exception/LogicExceptionTest.php

@@ -21,6 +21,9 @@ public function testShouldExtendLogicException()
         $this->assertClassExtends(\LogicException::class, LogicException::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new LogicException();

Tests/Consumption/Extension/LimitConsumedMessagesExtensionTest.php

@@ -16,6 +16,9 @@
 
 class LimitConsumedMessagesExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new LimitConsumedMessagesExtension(12345);

Tests/Consumption/Extension/LimitConsumerMemoryExtensionTest.php

@@ -17,6 +17,9 @@
 
 class LimitConsumerMemoryExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new LimitConsumerMemoryExtension(12345);

Tests/Consumption/Extension/LimitConsumptionTimeExtensionTest.php

@@ -17,6 +17,9 @@
 
 class LimitConsumptionTimeExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new LimitConsumptionTimeExtension(new \DateTime('+1 day'));

Tests/Consumption/Extension/LogExtensionTest.php

@@ -49,6 +49,9 @@ public function testShouldImplementPostMessageReceivedExtensionInterface()
         $this->assertClassImplements(PostMessageReceivedExtensionInterface::class, LogExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new LogExtension();

Tests/Consumption/Extension/LoggerExtensionTest.php

@@ -20,6 +20,9 @@ public function testShouldImplementInitLoggerExtensionInterface()
         $this->assertClassImplements(InitLoggerExtensionInterface::class, LoggerExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithLoggerAsFirstArgument()
     {
         new LoggerExtension($this->createLogger());

Tests/Consumption/Extension/NicenessExtensionTest.php

@@ -11,6 +11,9 @@
 
 class NicenessExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new NicenessExtension(0);

Tests/Consumption/Extension/ReplyExtensionTest.php

@@ -25,6 +25,9 @@ public function testShouldImplementPostMessageReceivedExtensionInterface()
         $this->assertClassImplements(PostMessageReceivedExtensionInterface::class, ReplyExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new ReplyExtension();

Tests/Consumption/FallbackSubscriptionConsumerTest.php

@@ -21,6 +21,9 @@ public function testShouldImplementSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new FallbackSubscriptionConsumer();
@@ -69,6 +72,9 @@ public function testThrowsIfTrySubscribeAnotherConsumerToAlreadySubscribedQueue(
         $subscriptionConsumer->subscribe($barConsumer, $barCallback);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testShouldAllowSubscribeSameConsumerAndCallbackSecondTime()
     {
         $subscriptionConsumer = new FallbackSubscriptionConsumer();

Tests/Consumption/QueueConsumerTest.php

@@ -39,16 +39,25 @@ class QueueConsumerTest extends TestCase
 {
     use ReadAttributeTrait;
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithAllArguments()
     {
         new QueueConsumer($this->createContextStub(), null, [], null, 0);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithContextOnly()
     {
         new QueueConsumer($this->createContextStub());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithContextAndSingleExtension()
     {
         new QueueConsumer($this->createContextStub(), $this->createExtension());

Tests/Router/RouteRecipientListProcessorTest.php

@@ -23,6 +23,9 @@ public function testShouldImplementProcessorInterface()
         $this->assertClassImplements(Processor::class, RouteRecipientListProcessor::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRouterAsFirstArgument()
     {
         new RouteRecipientListProcessor($this->createRecipientListRouterMock());