refactor(TestObjects.createUsersActivationFullDto): remove an intermediate local variable.

php-coder · php-coder · commit f9e96c8a9005 · 2020-01-28T00:03:41.000Z
diff --git a/src/test/java/ru/mystamps/web/service/TestObjects.java b/src/test/java/ru/mystamps/web/service/TestObjects.java
@@ -86,12 +86,11 @@ private TestObjects() {
 	}
 	
 	public static UsersActivationFullDto createUsersActivationFullDto() {
-		UsersActivationFullDto activation = new UsersActivationFullDto(
+		return new UsersActivationFullDto(
 			TEST_ACTIVATION_KEY,
 			TEST_EMAIL,
 			Random.date()
 		);
-		return activation;
 	}
 	
 	public static UsersActivationDto createUsersActivationDto() {

Original file line number	Diff line number	Diff line change
`@@ -86,12 +86,11 @@ private TestObjects() {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`public static UsersActivationFullDto createUsersActivationFullDto() {`
`89`		`- UsersActivationFullDto activation = new UsersActivationFullDto(`
	`89`	`+ return new UsersActivationFullDto(`
`90`	`90`	`TEST_ACTIVATION_KEY,`
`91`	`91`	`TEST_EMAIL,`
`92`	`92`	`Random.date()`
`93`	`93`	`);`
`94`		`- return activation;`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`public static UsersActivationDto createUsersActivationDto() {`