build: update robotframework-seleniumlibrary-java to 3.141.59.26535

Also remove workarounds for the issues that have been fixed in this release.

Fix #1166

Author: php-coder

pom.xml

@@ -550,7 +550,7 @@
 		<resources.plugin.version>3.1.0</resources.plugin.version>
 		<robotframework-httprequest.version>0.0.15</robotframework-httprequest.version>
 		<robotframework-plugin.version>1.5.1</robotframework-plugin.version>
-		<robotframework-selenium.version>3.141.59.2653</robotframework-selenium.version>
+		<robotframework-selenium.version>3.141.59.26535</robotframework-selenium.version>
 		<robotframework.version>3.1.2</robotframework.version>
 
 		<!-- Don't forget to update version in the ResourceUrl class and in the src/main/webapp/WEB-INF/views/series/add.html -->

src/test/robotframework/account/registration/misc-anonymous.robot

@@ -1,16 +1,15 @@
 *** Settings ***
 Documentation   Verify miscellaneous aspects of account registration from anonymous user
 Library         SeleniumLibrary
-Resource        ../../selenium.utils.robot
 Suite Setup     Before Test Suite
 Suite Teardown  Close Browser
 Force Tags      account  registration  misc
 
 *** Test Cases ***
 Email should be striped from leading and trailing spaces
-	Input Text                  id:email  ${SPACE * 2}test${SPACE * 2}
-	Submit Form                 id:register-account-form
-	Emailfield Value Should Be  id:email  test
+	Input Text                 id:email  ${SPACE * 2}test${SPACE * 2}
+	Submit Form                id:register-account-form
+	Textfield Value Should Be  id:email  test
 
 *** Keywords ***
 Before Test Suite

src/test/robotframework/collection/estimation/logic.robot

@@ -19,18 +19,14 @@ Series with its price should be taken into account
 	Submit Form                  id:add-series-form
 	Go To                        ${SITE_URL}/collection/paid/estimation
 	Table Cell Should Contain    collection-estimation  row=2  column=2  text=100.00 ${expectedCurrency}
-	# FIXME: use "Table Footer Should Contain" instead, when it will be fixed.
-	# See https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/issues/88
-	Table Header Should Contain  collection-estimation  100.00 ${expectedCurrency}
+	Table Footer Should Contain  collection-estimation  100.00 ${expectedCurrency}
 
 Series without price should be shown but not taken into account
 	Go To                        ${SITE_URL}/series/2
 	Submit Form                  id:add-series-form
 	Go To                        ${SITE_URL}/collection/paid/estimation
 	Table Cell Should Contain    collection-estimation  row=3  column=2  text=${EMPTY}
-	# FIXME: use "Table Footer Should Contain" instead, when it will be fixed.
-	# See https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/issues/88
-	Table Header Should Contain  collection-estimation  100.00 ${expectedCurrency}
+	Table Footer Should Contain  collection-estimation  100.00 ${expectedCurrency}
 
 *** Keywords ***
 Before Test Suite

src/test/robotframework/participant/creation/misc.robot

@@ -2,7 +2,6 @@
 Documentation    Verify miscellaneous aspects of participant creation
 Library          SeleniumLibrary
 Resource         ../../auth.steps.robot
-Resource         ../../selenium.utils.robot
 Suite Setup      Before Test Suite
 Suite Teardown   Close Browser
 Force Tags       participant  misc
@@ -13,7 +12,7 @@ Name and url should be stripped from leading and trailing spaces
 	Input Text                 id:url   ${SPACE * 2}url${SPACE * 2}
 	Submit Form                id:add-participant-form
 	Textfield Value Should Be  id:name  f
-	Urlfield Value Should Be   id:url   url
+	Textfield Value Should Be  id:url   url
 
 *** Keywords ***
 Before Test Suite

src/test/robotframework/selenium.utils.robot

@@ -8,22 +8,6 @@ Element Text Should Match Regexp
 	${text}=             Get Text  ${locator}
 	Should Match Regexp  ${text}  ${regexp}
 
-# Workaround for "Textfield Value Should Be" that causes NPE with <input type="url">:
-# https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/issues/52
-Urlfield Value Should Be
-	[Documentation]  Verifies text field locator has exactly text expected
-	[Arguments]      ${locator}  ${expected}
-	${value}=        Get Value  ${locator}
-	Should Be Equal  ${expected}  ${value}
-
-# Workaround for "Textfield Value Should Be" that causes NPE with <input type="email">:
-# https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/issues/52
-Emailfield Value Should Be
-	[Documentation]  Verifies text field locator has exactly text expected
-	[Arguments]      ${locator}  ${expected}
-	${value}=        Get Value  ${locator}
-	Should Be Equal  ${expected}  ${value}
-
 # We can't use "Select From List By Label" because
 # 1) it doesn't work with invisible elements (and selectize.js makes a field invisible)
 # 2) selectize.js dynamically creates a list of countries only when we click on a field

src/test/robotframework/series/import/request-logic.robot

@@ -26,7 +26,7 @@ Import series from an external site (in English, use category, country and date
 	Should Be Equal                  ${country}         Italy
 	Should Be Empty                  ${quantity}
 	Checkbox Should Be Selected      id:perforated
-	Urlfield Value Should Be         id:image-url       http://127.0.0.1:8080/image/1
+	Textfield Value Should Be        id:image-url       http://127.0.0.1:8080/image/1
 	Should Be Equal                  ${year}            2000
 	Input Text                       id:quantity  1
 	Submit Form                      id:create-series-form
@@ -64,7 +64,7 @@ Import series from an external site (in Russian, use description locator)
 	Should Be Equal              ${country}         Italy
 	Should Be Empty              ${quantity}
 	Checkbox Should Be Selected  id:perforated
-	Urlfield Value Should Be     id:image-url       http://localhost:8080/image/1
+	Textfield Value Should Be    id:image-url       http://localhost:8080/image/1
 	Should Be Equal              ${year}            2000
 
 Import series from external site with catalog numbers (use description locator)
@@ -107,7 +107,7 @@ Import series and series sale with a new seller from an external site
 	${group}=                   Get Selected List Label  id:seller-group
 	Should Be Equal             ${group}  example.com
 	Textfield Value Should Be   id:seller-name  Lando Livianus
-	Urlfield Value Should Be    id:seller-url   http://example.com/lando-livianus
+	Textfield Value Should Be   id:seller-url   http://example.com/lando-livianus
 	Submit Form                 id:create-series-form
 	# after importing a series, sale info should contain a new seller
 	${currentDate}=             Get Current Date  result_format=%d.%m.%Y

src/test/robotframework/series/sales/import/logic.robot

@@ -13,7 +13,7 @@ Import a series sale with an existing seller
 	Submit Form                  id:import-series-sale-form
 	# the original field is emptied after successful request,  so we wait for it
 	Wait Until Element Value Is  series-sale-url     ${EMPTY}
-	Urlfield Value Should Be     id:url              ${MOCK_SERVER}/series/sales/import/logic/existing-seller.html
+	Textfield Value Should Be    id:url              ${MOCK_SERVER}/series/sales/import/logic/existing-seller.html
 	List Selection Should Be     id:seller           Eicca Toppinen
 	Textfield Value Should Be    id:price            350
 	List Selection Should Be     id:currency         RUB

src/test/robotframework/series/sales/misc.robot

@@ -9,10 +9,10 @@ Force Tags       series  sales  misc
 
 *** Test Cases ***
 Url should be stripped from leading and trailing spaces
-	[Setup]                   Disable Client Validation
-	Input Text                id:url  ${SPACE * 2}bad-value${SPACE * 2}
-	Submit Form               id:add-series-sales-form
-	Urlfield Value Should Be  id:url  bad-value
+	[Setup]                    Disable Client Validation
+	Input Text                 id:url  ${SPACE * 2}bad-value${SPACE * 2}
+	Submit Form                id:add-series-sales-form
+	Textfield Value Should Be  id:url  bad-value
 
 *** Keywords ***
 Before Test Suite