Skip to content

Commit 4d15a16

Browse files
chore: add changelog and todo
Signed-off-by: Shivanshu Raj Shrivastava <shivanshu1333@gmail.com>
1 parent 2e5deca commit 4d15a16

File tree

1 file changed

+5
-0
lines changed
  • opentelemetry-otlp/src/exporter/tonic

1 file changed

+5
-0
lines changed

opentelemetry-otlp/src/exporter/tonic/trace.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@ impl SpanExporter for TonicTracesClient {
9090
}
9191

9292
fn shutdown(&self) -> OTelSdkResult {
93+
// ToDo: as part of https://github.com/open-telemetry/opentelemetry-rust/pull/2812
94+
// self is no longer mutable due to trait change for span exporter
95+
// the shutdown for gRPC needs to implemented and tracked in
96+
// https://github.com/open-telemetry/opentelemetry-rust/issues/2777
97+
//
9398
// match self.inner.take() {
9499
// Some(_) => Ok(()), // Successfully took `inner`, indicating a successful shutdown.
95100
// None => Err(OTelSdkError::AlreadyShutdown), // `inner` was already `None`, meaning it's already shut down.

0 commit comments

Comments
 (0)