Fix ESLint linting errors related to plugin:@typescript-eslint/strict-type-checked

nodeexx · nodeexx · commit 5a0b5f99783f · 2024-03-25T13:00:33.000+01:00
diff --git a/scripts/stack/_lib/utils/docker.js b/scripts/stack/_lib/utils/docker.js
@@ -40,8 +40,9 @@ export function getDockerContainerHealthStatus(containerName) {
         .trim()
     );
   } catch (e) {
+    const error = /** @type {Error} */ (e);
     throw new Error(
-      `Failed to get health status of ${containerName} container: ${e}`,
+      `Failed to get health status of ${containerName} container: ${error.message}`,
     );
   }
 
diff --git a/scripts/stack/local/all/api/down.js b/scripts/stack/local/all/api/down.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { DOCKER_COMPOSE_FILES, ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/all/e2e/down.js b/scripts/stack/local/all/e2e/down.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { DOCKER_COMPOSE_FILES, ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra-app/playwright/down.js b/scripts/stack/local/infra-app/playwright/down.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { DOCKER_COMPOSE_FILES, ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra-app/stack-only/down.js b/scripts/stack/local/infra-app/stack-only/down.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { DOCKER_COMPOSE_FILES, ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra/playwright/down.js b/scripts/stack/local/infra/playwright/down.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { DOCKER_COMPOSE_FILES, MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra/stack-only/app.js b/scripts/stack/local/infra/stack-only/app.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra/stack-only/down.js b/scripts/stack/local/infra/stack-only/down.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { DOCKER_COMPOSE_FILES, MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra/stack-only/migrate.js b/scripts/stack/local/infra/stack-only/migrate.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/scripts/stack/local/infra/stack-only/seed.js b/scripts/stack/local/infra/stack-only/seed.js
@@ -8,12 +8,14 @@ import { getPaths } from '../../../_lib/utils/paths.js';
 import { MANDATORY_ENV_VARS } from '../_lib/constants.js';
 import { ENV_FILE } from './_lib/constants.js';
 
-main().catch((e) => {
+try {
+  main();
+} catch (e) {
   console.error(e);
   process.exit(1);
-});
+}
 
-async function main() {
+function main() {
   const scriptPath = /** @type {string} */ (process.argv[1]);
 
   const paths = getPaths(scriptPath, ENV_FILE);
diff --git a/src/hooks.client.ts b/src/hooks.client.ts
@@ -27,7 +27,7 @@ setClientPosthogSessionId();
 
 logger.info('Starting the app client...');
 
-export const handleError = handleErrorWithSentry((async ({ error }) => {
+export const handleError = handleErrorWithSentry((({ error }) => {
   const message = 'Internal Client Error';
   if (dev) {
     console.error(message, error);
diff --git a/src/hooks.server.ts b/src/hooks.server.ts
@@ -54,7 +54,7 @@ export const handle = (async (input) => {
   return sequence(...nonMaintenanceModeHandles)(input);
 }) satisfies Handle;
 
-export const handleError = handleErrorWithSentry((async ({ error }) => {
+export const handleError = handleErrorWithSentry((({ error }) => {
   const message = 'Internal Server Error';
   console.error(message, error);
 
@@ -64,13 +64,15 @@ export const handleError = handleErrorWithSentry((async ({ error }) => {
   };
 }) satisfies HandleServerError);
 
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 process.on('SIGINT', async () => {
   console.info(
     'Got SIGINT (e.g. `Ctrl+C`). Graceful shutdown ',
     new Date().toISOString(),
   );
   await shutdownGracefully();
 });
+// eslint-disable-next-line @typescript-eslint/no-misused-promises
 process.on('SIGTERM', async () => {
   console.info(
     'Got SIGTERM (e.g. `docker container stop`). Graceful shutdown ',
diff --git a/src/lib/client/posthog/posthog-default-page-events-capture.configurator.ts b/src/lib/client/posthog/posthog-default-page-events-capture.configurator.ts
@@ -80,7 +80,7 @@ export class _PosthogDefaultPageEventsCaptureConfigurator {
       // WARN: Navigation after `popstate` event happens before this runs, so
       // page leave event is captured for the destination page, not the source
       // one. No solution for now (`beforeNavigate` also did not help).
-      if ($navigating && $navigating.willUnload === false) {
+      if ($navigating && !$navigating.willUnload) {
         this.capturePageLeaveEvent(_PageEventTrigger.BEFORE_NAVIGATE);
         return;
       }
diff --git a/src/lib/client/sentry/utils/index.ts b/src/lib/client/sentry/utils/index.ts
@@ -19,6 +19,6 @@ export function getClientSentryIntegrations(
 
 export function setClientPosthogSessionId(): void {
   if (posthog) {
-    sentry?.setTag(POSTHOG_SESSION_ID_TAG, getSessionId()!);
+    sentry?.setTag(POSTHOG_SESSION_ID_TAG, getSessionId());
   }
 }
diff --git a/src/lib/client/skeleton/utils/setup.utils.ts b/src/lib/client/skeleton/utils/setup.utils.ts
@@ -23,7 +23,7 @@ export function setupSkeletonPopup() {
     computePosition,
     autoUpdate,
     offset,
-    // @ts-ignore
+    // @ts-expect-error
     shift,
     flip,
     arrow,
diff --git a/src/lib/server/code-snippets/services/code-snippets.service.ts b/src/lib/server/code-snippets/services/code-snippets.service.ts
@@ -32,7 +32,7 @@ export class CodeSnippetsService {
       where: {
         is_deleted: false,
         ...(query?.filterBy === 'author' &&
-          query?.filterValue && { user_id: query?.filterValue }),
+          query.filterValue && { user_id: query.filterValue }),
       },
     });
 
@@ -44,7 +44,7 @@ export class CodeSnippetsService {
   ): Promise<number> {
     const itemCount = await this.getTotalItemCountByQuery(query);
     let pageCount = 1;
-    if (query?.count != null && query?.count > 0) {
+    if (query?.count != null && query.count > 0) {
       pageCount = Math.ceil(itemCount / query.count);
     }
 
@@ -53,26 +53,26 @@ export class CodeSnippetsService {
 
   async findManyByQuery(query?: FindCodeSnippetsQuery): Promise<CodeSnippet[]> {
     let skip: number | undefined;
-    if (query?.page != null && query?.page > 1 && query?.count != null) {
+    if (query?.page != null && query.page > 1 && query.count != null) {
       skip = (query.page - 1) * query.count;
     }
 
     let take: number | undefined;
     if (query?.count != null) {
-      take = query?.count;
+      take = query.count;
     }
 
     const codeSnippets = await prisma.codeSnippet.findMany({
       where: {
         is_deleted: false,
         ...(query?.filterBy === 'author' &&
-          query?.filterValue && { user_id: query?.filterValue }),
+          query.filterValue && { user_id: query.filterValue }),
       },
       ...(skip && { skip }),
       ...(take && { take }),
       ...(query?.sortBy && {
         orderBy: {
-          [query?.sortBy]: query?.sortOrder || 'asc',
+          [query.sortBy]: query.sortOrder || 'asc',
         },
       }),
     });
diff --git a/src/lib/server/lucia/hooks/add-auth-data-to-local.handle.node-test.ts b/src/lib/server/lucia/hooks/add-auth-data-to-local.handle.node-test.ts
@@ -5,6 +5,7 @@ import type * as utilsModule from '../utils';
 import { addAuthDataToLocalHandle } from './add-auth-data-to-local.handle';
 
 vi.mock('../client', async () => {
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
   const actual = (await vi.importActual('../client')) as typeof clientModule;
   return {
     ...actual,
@@ -15,6 +16,7 @@ vi.mock('../client', async () => {
 });
 
 vi.mock('../utils', async () => {
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
   const actual = (await vi.importActual('../utils')) as typeof utilsModule;
   return {
     ...actual,
diff --git a/src/lib/server/lucia/oauth/google/utils/sign-in.utils.ts b/src/lib/server/lucia/oauth/google/utils/sign-in.utils.ts
@@ -190,7 +190,7 @@ async function performOAuthAccountLinking(
 }
 
 async function verifyEmail(databaseUser: PrismaUser): Promise<void> {
-  if (databaseUser.email_verified === true) {
+  if (databaseUser.email_verified) {
     return;
   }
 
diff --git a/src/lib/server/posthog/client.ts b/src/lib/server/posthog/client.ts
@@ -21,7 +21,7 @@ export function setupNodePosthogClient(
 }
 
 function getNodePosthogClient(projectApiKey: string, apiHost: string): PostHog {
-  return new PostHog(projectApiKey!, {
-    host: apiHost!,
+  return new PostHog(projectApiKey, {
+    host: apiHost,
   });
 }
diff --git a/src/lib/server/superforms/testing/index.ts b/src/lib/server/superforms/testing/index.ts
@@ -6,7 +6,7 @@ export function getMockFormData(
   Object.entries(data).forEach(([key, value]) => {
     formData.append(key, value);
   });
-  const formDataFn = async () => formData;
+  const formDataFn = () => Promise.resolve(formData);
 
   return formDataFn;
 }
diff --git a/src/lib/shared/sentry/client.node-test.ts b/src/lib/shared/sentry/client.node-test.ts
@@ -37,7 +37,7 @@ describe(setupSentryClient.name, () => {
   });
 
   it('should configure the client', async () => {
-    await setupSentryClient({
+    setupSentryClient({
       dsn: 'mock-dsn',
       environment: 'localhost',
       origin: 'http://localhost:3000',
@@ -54,15 +54,15 @@ describe(setupSentryClient.name, () => {
   });
 
   it('should not configure the client if its already configured', async () => {
-    await setupSentryClient({
+    setupSentryClient({
       dsn: 'mock-dsn',
       environment: 'localhost',
       origin: 'http://localhost:3000',
     });
     // Reset the spy to check if it's called again
     vi.clearAllMocks();
 
-    await setupSentryClient({
+    setupSentryClient({
       dsn: 'mock-dsn',
       environment: 'localhost',
       origin: 'http://localhost:3000',
@@ -72,7 +72,7 @@ describe(setupSentryClient.name, () => {
   });
 
   it('should fail configuration of the client if configuration inputs are invalid', async () => {
-    await setupSentryClient({
+    setupSentryClient({
       dsn: undefined,
       environment: undefined,
       origin: 'http://localhost:3000',
@@ -90,7 +90,7 @@ describe(checkIfSentryClientConfigured.name, () => {
   });
 
   it('should not throw an error if client is configured', async () => {
-    await setupSentryClient({
+    setupSentryClient({
       dsn: 'mock-dsn',
       environment: 'localhost',
       origin: 'http://localhost:3000',
diff --git a/src/lib/shared/sveltekit/testing/test-helpers.ts b/src/lib/shared/sveltekit/testing/test-helpers.ts
@@ -101,7 +101,7 @@ export class SveltekitDefaultMocks {
 
         const updated = {
           subscribe: readable(false).subscribe,
-          check: async () => false,
+          check: () => Promise.resolve(false),
         };
 
         return { navigating, page, updated };
@@ -123,7 +123,7 @@ export class SveltekitDefaultMocks {
         subscribe(fn) {
           return getStores().updated.subscribe(fn);
         },
-        check: async () => false,
+        check: () => Promise.resolve(false),
       };
 
       return {
diff --git a/src/routes/(app)/(card-layout)/code-snippets/[id]/+page.server.ts b/src/routes/(app)/(card-layout)/code-snippets/[id]/+page.server.ts
@@ -53,7 +53,8 @@ export const actions = {
       authUser,
       form,
     );
-    if ((result as unknown as ActionFailure)?.status >= 400) {
+    const possibleActionFailure = result as unknown as ActionFailure;
+    if (possibleActionFailure.status && possibleActionFailure.status >= 400) {
       return result;
     }
 
diff --git a/src/routes/(app)/+page.server.ts b/src/routes/(app)/+page.server.ts
diff --git a/src/routes/(app)/page.server.module.ts b/src/routes/(app)/page.server.module.ts
diff --git a/src/routes/+layout.server.ts b/src/routes/+layout.server.ts
diff --git a/src/routes/api/healthcheck/+server.ts b/src/routes/api/healthcheck/+server.ts
diff --git a/src/routes/api/healthcheck/server.node-test.ts b/src/routes/api/healthcheck/server.node-test.ts
diff --git a/src/routes/maintenance/+page.server.ts b/src/routes/maintenance/+page.server.ts
diff --git a/tailwind.config.ts b/tailwind.config.ts
diff --git a/tests/playwright/api/tests/index.api-teardown.ts b/tests/playwright/api/tests/index.api-teardown.ts
diff --git a/tests/playwright/e2e/tests/index.e2e-teardown.ts b/tests/playwright/e2e/tests/index.e2e-teardown.ts

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ export class _PosthogDefaultPageEventsCaptureConfigurator {`
`80`	`80`	// WARN: Navigation after `popstate` event happens before this runs, so
`81`	`81`	`// page leave event is captured for the destination page, not the source`
`82`	`82`	// one. No solution for now (`beforeNavigate` also did not help).
`83`		`- if ($navigating && $navigating.willUnload === false) {`
	`83`	`+ if ($navigating && !$navigating.willUnload) {`
`84`	`84`	`this.capturePageLeaveEvent(_PageEventTrigger.BEFORE_NAVIGATE);`
`85`	`85`	`return;`
`86`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,6 @@ export function getClientSentryIntegrations(`
`19`	`19`
`20`	`20`	`export function setClientPosthogSessionId(): void {`
`21`	`21`	`if (posthog) {`
`22`		`- sentry?.setTag(POSTHOG_SESSION_ID_TAG, getSessionId()!);`
	`22`	`+ sentry?.setTag(POSTHOG_SESSION_ID_TAG, getSessionId());`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ async function performOAuthAccountLinking(`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`async function verifyEmail(databaseUser: PrismaUser): Promise<void> {`
`193`		`- if (databaseUser.email_verified === true) {`
	`193`	`+ if (databaseUser.email_verified) {`
`194`	`194`	`return;`
`195`	`195`	`}`
`196`	`196`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export function setupNodePosthogClient(`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`function getNodePosthogClient(projectApiKey: string, apiHost: string): PostHog {`
`24`		`- return new PostHog(projectApiKey!, {`
`25`		`- host: apiHost!,`
	`24`	`+ return new PostHog(projectApiKey, {`
	`25`	`+ host: apiHost,`
`26`	`26`	`});`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export function getMockFormData(`
`6`	`6`	`Object.entries(data).forEach(([key, value]) => {`
`7`	`7`	`formData.append(key, value);`
`8`	`8`	`});`
`9`		`- const formDataFn = async () => formData;`
	`9`	`+ const formDataFn = () => Promise.resolve(formData);`
`10`	`10`
`11`	`11`	`return formDataFn;`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ export const actions = {`
`53`	`53`	`authUser,`
`54`	`54`	`form,`
`55`	`55`	`);`
`56`		`- if ((result as unknown as ActionFailure)?.status >= 400) {`
	`56`	`+ const possibleActionFailure = result as unknown as ActionFailure;`
	`57`	`+ if (possibleActionFailure.status && possibleActionFailure.status >= 400) {`
`57`	`58`	`return result;`
`58`	`59`	`}`
`59`	`60`