Cascading is done during Session.Save and Commit even though cascade attribute is not set.

[nishantgupta204]

Hi There,

In our application when I am trying to save the new created object, there is cascading happening before and after saving to the properties of the object which are of collection type and entity type. I have not specified cascade attribute in my HBM. When I look at the code for Session.Save, there is mandatory cascading happening. This is causing performance bottlenecks when I call Session.Save. Is there any way we can avoid this code block, as the relationship and order in which objects are added is handled by application itself.

Please reply ASAP as we have lot of performance bottlenecks coming due to this

[bahusoid]

When I look at the code for Session.Save, there is mandatory cascading happening

Where exactly are you looking? Did you check the actual cascading code - all checks are there:

nhibernate-core/src/NHibernate/Engine/Cascade.cs

Lines 107 to 126 in 6ab71d0

	public void CascadeOn(IEntityPersister persister, object parent, object anything)
	{
	if (persister.HasCascades || action.RequiresNoCascadeChecking)
	{
	log.Info("processing cascade {0} for: {1}", action, persister.EntityName);
	IType[] types = persister.PropertyTypes;
	CascadeStyle[] cascadeStyles = persister.PropertyCascadeStyles;
	var uninitializedLazyProperties = persister.EntityMetamodel.BytecodeEnhancementMetadata.GetUninitializedLazyProperties(parent);
	for (int i = 0; i < types.Length; i++)
	{
	CascadeStyle style = cascadeStyles[i];
	string propertyName = persister.PropertyNames[i];
	if (uninitializedLazyProperties.Contains(propertyName) && persister.PropertyLaziness[i] && !action.PerformOnLazyProperty)
	{
	//do nothing to avoid a lazy property initialization
	continue;
	}
	if (style.DoCascade(action))

So if those persister.HasCascades and style.DoCascade checks don't work properly for you - please provide reproducible example.

[nishantgupta204]

Hi @bahusoid

Below is the code
#

nhibernate-core/src/NHibernate/Event/Default/AbstractFlushingEventListener.cs

Lines 187 to 202 in 2bd3c16

	protected virtual void PrepareEntityFlushes(IEventSource session)
	{
	log.Debug("processing flush-time cascades");
	ICollection list = IdentityMap.ConcurrentEntries(session.PersistenceContext.EntityEntries);
	//safe from concurrent modification because of how entryList() is implemented on IdentityMap
	foreach (DictionaryEntry me in list)
	{
	EntityEntry entry = (EntityEntry) me.Value;
	Status status = entry.Status;
	if (status == Status.Loaded || status == Status.Saving || status == Status.ReadOnly)
	{
	CascadeOnFlush(session, entry.Persister, me.Key, Anything);
	}
	}
	}

Here the iteration is going on for all the object in the PersistentContext( irrespective of whether the entities are modified or not) and checking for cascade.

[bahusoid]

irrespective of whether the entities are modified or not

You original concern was about cascading attributes: Cascading is done even though cascade attribute is not set

And now you are saying about modified entities. So what exactly is your issue? Is it really related to cascading attributes? CascadeOnFlush call should be no op if no cascading attributes are defined for entity - so I don't see any issues so far.

[nishantgupta204]

Hi,

My concern was this whole loop should be avoided when there is no cascade. Cascade check is inside the block 'CascadeOnFlush'. It should have been on top for loop as a default implementation. Is there any specific reason to do this?

Right now I have fixed it having custom implementation as suggested by now.

Thanks

[bahusoid]

I don't get how "no cascade" case can be determined outside of the loop. But feel free to provide PR with suggested fix.

[bahusoid]

Is there any way we can avoid this code block

It looks like you need some custom flushing logic. You can implement it in your own custom class implementing IFlushEventListener (or by overriding DefaultFlushEventListener or AbstractFlushingEventListener). And then use it:

//Somewhere before session factory is created:
configuration.EventListeners.FlushEventListeners = new[]{ new  YourCustomFlushEventListener()};

Or in xml:

<hibernate-configuration>
    <session-factory>
        ...
        <event type="flush">
            <listener class="YourCustomFlushEventListener"/>
        </event>
    </session-factory>
</hibernate-configuration>