Unskip sap tests for concat

hazzik · hazzik · commit 377280ab607c · 2022-01-02T11:27:00.000+13:00
diff --git a/src/NHibernate.Test/Async/Criteria/Lambda/FunctionsIntegrationFixture.cs b/src/NHibernate.Test/Async/Criteria/Lambda/FunctionsIntegrationFixture.cs
@@ -145,9 +145,6 @@ public async Task FunctionsToLowerToUpperAsync()
 		[Test]
 		public async Task ConcatAsync()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			using (var s = OpenSession())
 			using (s.BeginTransaction())
 			{
diff --git a/src/NHibernate.Test/Async/Criteria/ProjectionsTest.cs b/src/NHibernate.Test/Async/Criteria/ProjectionsTest.cs
@@ -69,9 +69,6 @@ protected override void OnTearDown()
 		[Test]
 		public async Task UsingSqlFunctions_ConcatAsync()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = await (session.CreateCriteria(typeof(Student))
@@ -89,12 +86,8 @@ public async Task UsingSqlFunctions_ConcatAsync()
 		[Test]
 		public async Task UsingSqlFunctions_Concat_WithCastAsync()
 		{
-			if(Dialect is Oracle8iDialect)
-			{
+			if (Dialect is Oracle8iDialect)
 				Assert.Ignore("Not supported by the active dialect:{0}.", Dialect);
-			}
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
 
 			using (ISession session = Sfi.OpenSession())
 			{
diff --git a/src/NHibernate.Test/Async/Linq/LinqQuerySamples.cs b/src/NHibernate.Test/Async/Linq/LinqQuerySamples.cs
@@ -1416,9 +1416,6 @@ public void ReplaceFunctionWithNullArgumentAsync()
 		[Test(Description = "GH-2860")]
 		public async Task StringFormatWithTrimAsync()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			var q =
 				from e in db.Employees
 				select new { Name = $"{e.FirstName} {e.LastName}".Trim(), Phone = e.Address.PhoneNumber };
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/NH1280/NH1280Fixture.cs b/src/NHibernate.Test/Async/NHSpecificTest/NH1280/NH1280Fixture.cs
@@ -52,9 +52,6 @@ protected override void OnTearDown()
 		[Test]
 		public async Task HavingUsingSqlFunctions_ConcatAsync()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			using (ISession s = OpenSession())
 			using (ITransaction tx = s.BeginTransaction())
 			{
diff --git a/src/NHibernate.Test/Criteria/Lambda/FunctionsIntegrationFixture.cs b/src/NHibernate.Test/Criteria/Lambda/FunctionsIntegrationFixture.cs
@@ -134,9 +134,6 @@ public void FunctionsToLowerToUpper()
 		[Test]
 		public void Concat()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			using (var s = OpenSession())
 			using (s.BeginTransaction())
 			{
diff --git a/src/NHibernate.Test/Criteria/ProjectionsTest.cs b/src/NHibernate.Test/Criteria/ProjectionsTest.cs
@@ -58,9 +58,6 @@ protected override void OnTearDown()
 		[Test]
 		public void UsingSqlFunctions_Concat()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = session.CreateCriteria(typeof(Student))
@@ -78,12 +75,8 @@ public void UsingSqlFunctions_Concat()
 		[Test]
 		public void UsingSqlFunctions_Concat_WithCast()
 		{
-			if(Dialect is Oracle8iDialect)
-			{
+			if (Dialect is Oracle8iDialect)
 				Assert.Ignore("Not supported by the active dialect:{0}.", Dialect);
-			}
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
 
 			using (ISession session = Sfi.OpenSession())
 			{
diff --git a/src/NHibernate.Test/Linq/LinqQuerySamples.cs b/src/NHibernate.Test/Linq/LinqQuerySamples.cs
@@ -2001,9 +2001,6 @@ public void ReplaceFunctionWithNullArgument()
 		[Test(Description = "GH-2860")]
 		public void StringFormatWithTrim()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			var q =
 				from e in db.Employees
 				select new { Name = $"{e.FirstName} {e.LastName}".Trim(), Phone = e.Address.PhoneNumber };
diff --git a/src/NHibernate.Test/NHSpecificTest/NH1280/NH1280Fixture.cs b/src/NHibernate.Test/NHSpecificTest/NH1280/NH1280Fixture.cs
@@ -41,9 +41,6 @@ protected override void OnTearDown()
 		[Test]
 		public void HavingUsingSqlFunctions_Concat()
 		{
-			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
-				Assert.Ignore("Current dialect does not support this test");
-
 			using (ISession s = OpenSession())
 			using (ITransaction tx = s.BeginTransaction())
 			{

Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,6 @@ public async Task FunctionsToLowerToUpperAsync()`
`145`	`145`	`[Test]`
`146`	`146`	`public async Task ConcatAsync()`
`147`	`147`	`{`
`148`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`149`		`- Assert.Ignore("Current dialect does not support this test");`
`150`		`-`
`151`	`148`	`using (var s = OpenSession())`
`152`	`149`	`using (s.BeginTransaction())`
`153`	`150`	`{`
Original file line number	Diff line number	Diff line change
`@@ -69,9 +69,6 @@ protected override void OnTearDown()`
`69`	`69`	`[Test]`
`70`	`70`	`public async Task UsingSqlFunctions_ConcatAsync()`
`71`	`71`	`{`
`72`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`73`		`- Assert.Ignore("Current dialect does not support this test");`
`74`		`-`
`75`	`72`	`using (ISession session = Sfi.OpenSession())`
`76`	`73`	`{`
`77`	`74`	`string result = await (session.CreateCriteria(typeof(Student))`
`@@ -89,12 +86,8 @@ public async Task UsingSqlFunctions_ConcatAsync()`
`89`	`86`	`[Test]`
`90`	`87`	`public async Task UsingSqlFunctions_Concat_WithCastAsync()`
`91`	`88`	`{`
`92`		`- if(Dialect is Oracle8iDialect)`
`93`		`- {`
	`89`	`+ if (Dialect is Oracle8iDialect)`
`94`	`90`	`Assert.Ignore("Not supported by the active dialect:{0}.", Dialect);`
`95`		`- }`
`96`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`97`		`- Assert.Ignore("Current dialect does not support this test");`
`98`	`91`
`99`	`92`	`using (ISession session = Sfi.OpenSession())`
`100`	`93`	`{`
Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,6 @@ protected override void OnTearDown()`
`52`	`52`	`[Test]`
`53`	`53`	`public async Task HavingUsingSqlFunctions_ConcatAsync()`
`54`	`54`	`{`
`55`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`56`		`- Assert.Ignore("Current dialect does not support this test");`
`57`		`-`
`58`	`55`	`using (ISession s = OpenSession())`
`59`	`56`	`using (ITransaction tx = s.BeginTransaction())`
`60`	`57`	`{`
Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,6 @@ public void FunctionsToLowerToUpper()`
`134`	`134`	`[Test]`
`135`	`135`	`public void Concat()`
`136`	`136`	`{`
`137`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`138`		`- Assert.Ignore("Current dialect does not support this test");`
`139`		`-`
`140`	`137`	`using (var s = OpenSession())`
`141`	`138`	`using (s.BeginTransaction())`
`142`	`139`	`{`
Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,6 @@ protected override void OnTearDown()`
`58`	`58`	`[Test]`
`59`	`59`	`public void UsingSqlFunctions_Concat()`
`60`	`60`	`{`
`61`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`62`		`- Assert.Ignore("Current dialect does not support this test");`
`63`		`-`
`64`	`61`	`using (ISession session = Sfi.OpenSession())`
`65`	`62`	`{`
`66`	`63`	`string result = session.CreateCriteria(typeof(Student))`
`@@ -78,12 +75,8 @@ public void UsingSqlFunctions_Concat()`
`78`	`75`	`[Test]`
`79`	`76`	`public void UsingSqlFunctions_Concat_WithCast()`
`80`	`77`	`{`
`81`		`- if(Dialect is Oracle8iDialect)`
`82`		`- {`
	`78`	`+ if (Dialect is Oracle8iDialect)`
`83`	`79`	`Assert.Ignore("Not supported by the active dialect:{0}.", Dialect);`
`84`		`- }`
`85`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`86`		`- Assert.Ignore("Current dialect does not support this test");`
`87`	`80`
`88`	`81`	`using (ISession session = Sfi.OpenSession())`
`89`	`82`	`{`
Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,6 @@ protected override void OnTearDown()`
`41`	`41`	`[Test]`
`42`	`42`	`public void HavingUsingSqlFunctions_Concat()`
`43`	`43`	`{`
`44`		`- if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)`
`45`		`- Assert.Ignore("Current dialect does not support this test");`
`46`		`-`
`47`	`44`	`using (ISession s = OpenSession())`
`48`	`45`	`using (ITransaction tx = s.BeginTransaction())`
`49`	`46`	`{`