Merge 5.5.1 into master

Author: fredericDelaporte

releasenotes.txt

@@ -1,4 +1,21 @@
-Build 5.5.0
+Build 5.5.1
+=============================
+
+Release notes - NHibernate - Version 5.5.1
+
+3 issues were resolved in this release.
+
+** Bug
+
+   * #3465 Invalid SQL created for some joins in a subquery
+
+** Task
+
+   * #3509 Release 5.5.1
+   * #3508 Merge 5.4.8 into 5.5.x
+
+
+Build 5.5.0
 =============================
 
 Release notes - NHibernate - Version 5.5.0
@@ -88,6 +105,22 @@ Release notes - NHibernate - Version 5.5.0
    * #3412 Revive hql ParsingFixture
 
 
+Build 5.4.8
+=============================
+
+Release notes - NHibernate - Version 5.4.8
+
+2 issues were resolved in this release.
+
+** Bug
+
+   * #3489 Inserting multiple associations of the same entity fails
+
+** Task
+
+   * #3507 Release 5.4.8
+
+
 Build 5.4.7
 =============================
 

src/NHibernate.Test/Async/BulkManipulation/HQLBulkOperations.cs

@@ -43,5 +43,21 @@ public async Task SimpleDeleteAsync()
 				await (tx.CommitAsync());
 			}
 		}
+
+		[Test]
+		public async Task InsertFromSelectWithMultipleAssociationsAsync()
+		{
+			Assume.That(TestDialect.NativeGeneratorSupportsBulkInsertion,
+				"The dialect does not support a native generator compatible with bulk insertion.");
+
+			using var s = OpenSession();
+			using var tx = s.BeginTransaction();
+
+			await (s.CreateQuery("insert into Enrolment (Course, Student)" +
+				" select e.Course, e.Student from Enrolment e")
+				.ExecuteUpdateAsync());
+
+			await (tx.CommitAsync());
+		}
 	}
-}
+}

src/NHibernate.Test/Async/NHSpecificTest/GH3465/Fixture.cs

@@ -0,0 +1,31 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by AsyncGenerator.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+
+using System.Linq;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.GH3465
+{
+	using System.Threading.Tasks;
+	[TestFixture]
+	public class FixtureAsync : BugTestCase
+	{
+		[Test]
+		public void ThetaJoinSubQueryAsync()
+		{
+			using (var session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				var query = session.CreateQuery("select e.Id from EntityA e where exists (from e.Children b, EntityC c)");
+				Assert.DoesNotThrowAsync(() => query.ListAsync());
+			}
+		}
+	}
+}

src/NHibernate.Test/BulkManipulation/Course.cs

@@ -0,0 +1,8 @@
+namespace NHibernate.Test.BulkManipulation
+{
+	public class Course
+	{
+		public virtual long CourseId { get; set; }
+		public virtual string Description { get; set; }
+	}
+}

src/NHibernate.Test/BulkManipulation/Enrolment.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace NHibernate.Test.BulkManipulation
+{
+	[Serializable]
+	public class Enrolment
+	{
+		public virtual long EnrolmentId { get; set; }
+		public virtual Student Student { get; set; }
+		public virtual Course Course { get; set; }
+	}
+}

src/NHibernate.Test/BulkManipulation/Enrolment.hbm.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+<hibernate-mapping
+	xmlns="urn:nhibernate-mapping-2.2"
+	assembly="NHibernate.Test"
+	namespace="NHibernate.Test.BulkManipulation">
+
+  <class name="Course">
+    <id name="CourseId">
+      <generator class="native" />
+    </id>
+    <property name="Description" />
+  </class>
+
+  <class name="Student">
+    <id name="StudentId">
+      <generator class="native" />
+    </id>
+    <property name="Name" />
+  </class>
+
+  <class name="Enrolment">
+    <id name="EnrolmentId">
+      <generator class="native" />
+    </id>
+    <many-to-one name="Student" column="StudentId" class="Student" />
+    <many-to-one name="Course" column="CourseId" class="Course" />
+  </class>
+
+</hibernate-mapping>

src/NHibernate.Test/BulkManipulation/HQLBulkOperations.cs

@@ -32,5 +32,21 @@ public void SimpleDelete()
 				tx.Commit();
 			}
 		}
+
+		[Test]
+		public void InsertFromSelectWithMultipleAssociations()
+		{
+			Assume.That(TestDialect.NativeGeneratorSupportsBulkInsertion,
+				"The dialect does not support a native generator compatible with bulk insertion.");
+
+			using var s = OpenSession();
+			using var tx = s.BeginTransaction();
+
+			s.CreateQuery("insert into Enrolment (Course, Student)" +
+				" select e.Course, e.Student from Enrolment e")
+				.ExecuteUpdate();
+
+			tx.Commit();
+		}
 	}
-}
+}

src/NHibernate.Test/BulkManipulation/Student.cs

@@ -0,0 +1,8 @@
+namespace NHibernate.Test.BulkManipulation
+{
+	public class Student
+	{
+		public virtual long StudentId { get; set; }
+		public virtual string Name { get; set; }
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3465/Entities.cs

@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.GH3465
+{
+	class EntityA
+	{
+		public virtual Guid Id { get; set; }
+		public virtual ISet<EntityB> Children { get; set; }
+	}
+	class EntityB
+	{
+		public virtual Guid Id { get; set; }
+		public virtual EntityA Parent { get; set; }
+	}
+	class EntityC
+	{
+		public virtual Guid Id { get; set; }
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3465/Fixture.cs

@@ -0,0 +1,20 @@
+using System.Linq;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.GH3465
+{
+	[TestFixture]
+	public class Fixture : BugTestCase
+	{
+		[Test]
+		public void ThetaJoinSubQuery()
+		{
+			using (var session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				var query = session.CreateQuery("select e.Id from EntityA e where exists (from e.Children b, EntityC c)");
+				Assert.DoesNotThrow(() => query.List());
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH3465/Mappings.hbm.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test"
+                   namespace="NHibernate.Test.NHSpecificTest.GH3465">
+  <class name="EntityA">
+    <id name="Id" generator="guid.comb" />
+    <set name="Children" cascade="all-delete-orphan" inverse="true">
+      <key column="EntityAId" />
+      <one-to-many class="EntityB" />
+    </set>
+  </class>
+  <class name="EntityB">
+    <id name="Id" generator="guid.comb" />
+    <many-to-one name="Parent" column="EntityAId" class="EntityA" not-null="true" />
+  </class>
+  <class name="EntityC">
+    <id name="Id" generator="guid.comb" />
+  </class>
+</hibernate-mapping>

src/NHibernate/Hql/Ast/ANTLR/Tree/FromElement.cs

@@ -716,7 +716,7 @@ public void SetOrigin(FromElement origin, bool manyToMany)
 					JoinSequence.SetUseThetaStyle(true);
 				}
 			}
-			else
+			else if (Walker.CurrentClauseType != HqlSqlWalker.FROM)
 			{
 				FromClause.AppendFromElement(this);
 			}

src/NHibernate/Hql/Ast/ANTLR/Tree/SelectClause.cs

@@ -494,7 +494,7 @@ private void RenderNonScalarIdentifiers(
 				}
 
 				var node = (IASTNode) e;
-				if (processedElements.Add(fromElement))
+				if (Walker.IsShallowQuery && node.Type == SqlGenerator.DOT || processedElements.Add(fromElement))
 				{
 					combinedFromElements.Add(fromElement);
 					RenderNonScalarIdentifiers(fromElement, inheritedExpressions.ContainsKey(e) ? null : e, appender);