Skip to content

Commit 27d65ac

Browse files
committed
Add more review feedback
1 parent 8abf3a5 commit 27d65ac

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

content/ngf/installation/installing-ngf/deploy-data-plane.md

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Using `kubectl get` you can see the NGINX Deployment:
8181
```shell
8282
kubectl get deployments
8383
```
84-
```text ⎈ kind-kind
84+
```text
8585
NAME READY UP-TO-DATE AVAILABLE AGE
8686
cafe-nginx 1/1 1 1 3m18s
8787
```
@@ -91,9 +91,9 @@ You can also see the Service fronting it:
9191
```shell
9292
kubectl get services
9393
```
94-
```text ⎈ kind-kind
95-
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
96-
cafe-nginx NodePort 10.96.125.117 <none> 80:30180/TCP 5m2s
94+
```text
95+
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
96+
cafe-nginx LoadBalancer 10.96.125.117 <pending> 80:30180/TCP 5m2s
9797
```
9898

9999
The Service type can be changed, explained in the next section.
@@ -104,26 +104,26 @@ The NginxProxy custom resource can modify the provisioning of the Service object
104104

105105
{{< note >}} Updating most Kubernetes related fields in NginxProxy will trigger a restart of the related resources. {{< /note >}}
106106

107-
An NginxProxy resource is created by default after deploying NGINX Gateway Fabric. This NginxProxy resource is attached to the GatewayClass (created on NGINX Gateway Fabric deployment), and
107+
An NginxProxy resource is created by default after deploying NGINX Gateway Fabric. This NginxProxy resource is attached to the GatewayClass (created on NGINX Gateway Fabric installation), and
108108
its settings are applied globally to all Gateways.
109109

110110
Use `kubectl get` and `kubectl describe` to get some more information on the resource:
111111

112112
```shell
113113
kubectl get nginxproxies -A
114114
```
115-
```text ⎈ kind-kind
115+
```text
116116
NAMESPACE NAME AGE
117117
nginx-gateway ngf-proxy-config 19h
118118
```
119119

120120
```shell
121121
kubectl describe nginxproxy -n nginx-gateway ngf-proxy-config
122122
```
123-
```text ⎈ kind-kind
123+
```text
124124
Name: ngf-proxy-config
125125
Namespace: nginx-gateway
126-
Labels: app.kubernetes.io/instance=mngf
126+
Labels: app.kubernetes.io/instance=ngf
127127
app.kubernetes.io/managed-by=Helm
128128
app.kubernetes.io/name=nginx-gateway-fabric
129129
app.kubernetes.io/version=edge
@@ -149,7 +149,7 @@ Spec:
149149
Replicas: 1
150150
Service:
151151
External Traffic Policy: Local
152-
Type: NodePort
152+
Type: LoadBalancer
153153
Events: <none>
154154
```
155155

@@ -159,24 +159,25 @@ Under `Spec.Kubernetes` you can see a few things:
159159
- How many NGINX Deployment replicas are specified
160160
- The type of Service and external traffic policy
161161

162-
{{< note >}} Depending on installation configuration, the default NginxProxy settings may be slightly different from what is shown in the example. {{< /note >}}
162+
{{< note >}} Depending on installation configuration, the default NginxProxy settings may be slightly different from what is shown in the example.
163+
For more information on NginxProxy and its configurable fields, see the [API reference]({{< ref "/ngf/reference/api.md" >}}). {{< /note >}}
163164

164165
Modify the NginxProxy resource to change the type of Service.
165166

166167
Use `kubectl edit` to modify the default NginxProxy and insert the following under `spec.kubernetes.service`:
167168

168169
```yaml
169-
type: LoadBalancer
170+
type: NodePort
170171
```
171172
172173
After saving the changes, use `kubectl get` on the service, and you should see the service type has changed to LoadBalancer.
173174

174175
```shell
175176
kubectl get service cafe-nginx
176177
```
177-
```text ⎈ kind-kind
178+
```text
178179
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
179-
cafe-nginx LoadBalancer 10.96.172.204 <pending> 80:32615/TCP 3h5m
180+
cafe-nginx NodePort 10.96.172.204 <none> 80:32615/TCP 3h5m
180181
```
181182

182183
### How to set annotations and labels on provisioned resources
@@ -200,7 +201,7 @@ After saving the changes, check the Service and NGINX deployment with `kubectl d
200201
```shell
201202
kubectl describe deployment cafe
202203
```
203-
```text 1m 52s ⎈ kind-kind
204+
```text
204205
Name: cafe-nginx
205206
Namespace: default
206207
CreationTimestamp: Mon, 05 May 2025 16:49:33 -0700
@@ -222,7 +223,7 @@ Pod Template:
222223
```shell
223224
kubectl describe service cafe-nginx
224225
```
225-
```text ⎈ kind-kind
226+
```text
226227
Name: cafe-nginx
227228
Namespace: default
228229
Labels: app.kubernetes.io/instance=ngf

0 commit comments

Comments
 (0)