Add NoDiscard attribute to 'withCollection' methods

GromNaN · GromNaN · commit 66ed280ca9d7 · 2025-05-09T14:17:16.000+02:00
diff --git a/composer.json b/composer.json
@@ -13,7 +13,8 @@
         "php": "^8.1",
         "ext-mongodb": "^2.0",
         "composer-runtime-api": "^2.0",
-        "psr/log": "^1.1.4|^2|^3"
+        "psr/log": "^1.1.4|^2|^3",
+        "symfony/polyfill-php85": "^1.32"
     },
     "require-dev": {
         "doctrine/coding-standard": "^12.0",
diff --git a/src/ClientBulkWrite.php b/src/ClientBulkWrite.php
@@ -24,6 +24,7 @@
 use MongoDB\Driver\BulkWriteCommand;
 use MongoDB\Driver\Manager;
 use MongoDB\Exception\InvalidArgumentException;
+use NoDiscard;
 use stdClass;
 
 use function is_array;
@@ -42,6 +43,7 @@ private function __construct(
     ) {
     }
 
+    #[NoDiscard]
     public static function createWithCollection(Collection $collection, array $options = []): self
     {
         $options += ['ordered' => true];
@@ -224,6 +226,7 @@ public function updateOne(array|object $filter, array|object $update, array $opt
         return $this;
     }
 
+    #[NoDiscard]
     public function withCollection(Collection $collection): self
     {
         /* Prohibit mixing Collections associated with different Manager

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`use MongoDB\Driver\BulkWriteCommand;`
`25`	`25`	`use MongoDB\Driver\Manager;`
`26`	`26`	`use MongoDB\Exception\InvalidArgumentException;`
	`27`	`+use NoDiscard;`
`27`	`28`	`use stdClass;`
`28`	`29`
`29`	`30`	`use function is_array;`
`@@ -42,6 +43,7 @@ private function __construct(`
`42`	`43`	`) {`
`43`	`44`	`}`
`44`	`45`
	`46`	`+ #[NoDiscard]`
`45`	`47`	`public static function createWithCollection(Collection $collection, array $options = []): self`
`46`	`48`	`{`
`47`	`49`	`$options += ['ordered' => true];`
`@@ -224,6 +226,7 @@ public function updateOne(array\|object $filter, array\|object $update, array $opt`
`224`	`226`	`return $this;`
`225`	`227`	`}`
`226`	`228`
	`229`	`+ #[NoDiscard]`
`227`	`230`	`public function withCollection(Collection $collection): self`
`228`	`231`	`{`
`229`	`232`	`/* Prohibit mixing Collections associated with different Manager`