fix(graphql): resolve duplicate events on socket reconnect

aarsham · aarsham · commit be11b4cd1210 · 2024-04-08T16:37:12.000+03:30
Resolved an issue in WebSocketClient where multiple listeners were added to `waitForConnectedState` when socket reconnects after subscription been requtesed with disconnected socket, causing duplicate events to be received by subscriptions.
diff --git a/packages/graphql/lib/src/links/websocket_link/websocket_client.dart b/packages/graphql/lib/src/links/websocket_link/websocket_client.dart
@@ -502,6 +502,7 @@ class SocketClient {
             )
           : waitForConnectedStateWithoutTimeout;
 
+      sub?.cancel();
       sub = waitForConnectedState.listen((_) {
         final Stream<GraphQLSocketMessage> dataErrorComplete = _messages.where(
           (GraphQLSocketMessage message) {

Original file line number	Diff line number	Diff line change
`@@ -502,6 +502,7 @@ class SocketClient {`
`502`	`502`	`)`
`503`	`503`	`: waitForConnectedStateWithoutTimeout;`
`504`	`504`
	`505`	`+ sub?.cancel();`
`505`	`506`	`sub = waitForConnectedState.listen((_) {`
`506`	`507`	`final Stream<GraphQLSocketMessage> dataErrorComplete = _messages.where(`
`507`	`508`	`(GraphQLSocketMessage message) {`