Skip to content

Block & Blob Downloaders need manage the empty peerbook async #1317

Open
@rodrigo-o

Description

@rodrigo-o

Right now we have tech debt in how both block and blob downloaders manage the empty peerbook case.

Before #1314, the node hanged if no we run out peers due to #1308. After #1314 this raise, before it continually sleep making impossible for LibP2P to handle new peers. This needs to instead being delayed asynchronously to allow new peers to be part of the peerbook.

After #1314, this issue is less common due to a better penalization scheme and more time in the begining for peer discovery, but still possible if all initial peers aren't responding, luckily this isn't the case most of the times and it is an issue mostly at the start of the node where we have a small number of peers.

If this proves to be more common than anticipated it need to move from P2 to P1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2This is a nice to have. Improves usability of the app or the libraries, but it's not urgent.bugSomething isn't working

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions