Add signal catch to stop the server gracefully

Author: astraw99

.gitignore

@@ -1 +1,2 @@
 /bin
+.idea

cmd/hostpathplugin/main.go

@@ -44,7 +44,7 @@ func main() {
 		VendorVersion: version,
 	}
 
-	flag.StringVar(&cfg.Endpoint, "endpoint", "unix://tmp/csi.sock", "CSI endpoint")
+	flag.StringVar(&cfg.Endpoint, "endpoint", "unix:///tmp/csi.sock", "CSI endpoint")
 	flag.StringVar(&cfg.DriverName, "drivername", "hostpath.csi.k8s.io", "name of the driver")
 	flag.StringVar(&cfg.StateDir, "statedir", "/csi-data-dir", "directory for storing state information across driver restarts, volumes and snapshots")
 	flag.StringVar(&cfg.NodeID, "nodeid", "", "node id")
@@ -113,9 +113,18 @@ func main() {
 		os.Exit(1)
 	}
 
-	if err := driver.Run(); err != nil {
+	// Wait for signal
+	stopCh := make(chan os.Signal, 1)
+	sigs := []os.Signal{
+		syscall.SIGTERM,
+		syscall.SIGHUP,
+		syscall.SIGINT,
+		syscall.SIGQUIT,
+	}
+	signal.Notify(stopCh, sigs...)
+
+	if err := driver.Run(stopCh); err != nil {
 		fmt.Printf("Failed to run driver: %s", err.Error())
 		os.Exit(1)
-
 	}
 }

internal/endpoint/endpoint.go

@@ -43,7 +43,6 @@ func Listen(endpoint string) (net.Listener, func(), error) {
 
 	cleanup := func() {}
 	if proto == "unix" {
-		addr = "/" + addr
 		if err := os.Remove(addr); err != nil && !os.IsNotExist(err) { //nolint: vetshadow
 			return nil, nil, fmt.Errorf("%s: %q", addr, err)
 		}

pkg/hostpath/hostpath.go

@@ -120,11 +120,13 @@ func NewHostPathDriver(cfg Config) (*hostPath, error) {
 	return hp, nil
 }
 
-func (hp *hostPath) Run() error {
+func (hp *hostPath) Run(stopCh <-chan os.Signal) error {
 	s := NewNonBlockingGRPCServer()
 	// hp itself implements ControllerServer, NodeServer, and IdentityServer.
 	s.Start(hp.config.Endpoint, hp, hp, hp)
-	s.Wait()
+
+	<-stopCh
+	s.Stop()
 
 	return nil
 }

pkg/hostpath/nodeserver.go

@@ -503,7 +503,7 @@ func (hp *hostPath) NodeExpandVolume(ctx context.Context, req *csi.NodeExpandVol
 	switch m := info.Mode(); {
 	case m.IsDir():
 		if vol.VolAccessType != state.MountAccess {
-			return nil, status.Errorf(codes.InvalidArgument, "Volume %s is not a directory", volID)
+			return nil, status.Errorf(codes.InvalidArgument, "Volume %s is not a mounted filesystem", volID)
 		}
 	case m&os.ModeDevice != 0:
 		if vol.VolAccessType != state.BlockAccess {

pkg/hostpath/server.go

@@ -18,7 +18,6 @@ package hostpath
 
 import (
 	"encoding/json"
-	"sync"
 
 	"github.com/golang/glog"
 	"golang.org/x/net/context"
@@ -35,24 +34,17 @@ func NewNonBlockingGRPCServer() *nonBlockingGRPCServer {
 
 // NonBlocking server
 type nonBlockingGRPCServer struct {
-	wg      sync.WaitGroup
 	server  *grpc.Server
 	cleanup func()
 }
 
 func (s *nonBlockingGRPCServer) Start(endpoint string, ids csi.IdentityServer, cs csi.ControllerServer, ns csi.NodeServer) {
 
-	s.wg.Add(1)
-
 	go s.serve(endpoint, ids, cs, ns)
 
 	return
 }
 
-func (s *nonBlockingGRPCServer) Wait() {
-	s.wg.Wait()
-}
-
 func (s *nonBlockingGRPCServer) Stop() {
 	s.server.GracefulStop()
 	s.cleanup()
@@ -89,7 +81,6 @@ func (s *nonBlockingGRPCServer) serve(ep string, ids csi.IdentityServer, cs csi.
 	glog.Infof("Listening for connections on address: %#v", listener.Addr())
 
 	server.Serve(listener)
-
 }
 
 func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {