Skip to content

Commit bec62e0

Browse files
committed
Make expand/collapse language more precise
1 parent 1db3d31 commit bec62e0

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#### Properties
1313

1414
* `id`: No longer generates a random UUID when empty
15-
* `lang`: Replaced `toggle` key with `collapseNode` and `expandNode`
15+
* `lang`: Replaced `toggle` key with `collapseNode` and `expandNode` to better reflect state (#275)
1616

1717
#### Styling
1818

@@ -28,7 +28,7 @@
2828

2929
### Other
3030

31-
* [#329] Add React 18 to the peer dependency list (**Note**: React 18 is not part of the automatic testing, but should work)
31+
* [#329]: Add React 18 to the peer dependency list (**Note**: React 18 is not part of the automatic testing, but should work)
3232

3333
## [v1.7.3](https://github.com/jakezatecky/react-checkbox-tree/compare/v1.7.2...v1.7.3) (2022-05-23)
3434

src/js/lang/default.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export default {
22
collapseAll: 'Collapse all',
3-
collapseNode: 'Collapse',
3+
collapseNode: 'Collapse node',
44
expandAll: 'Expand all',
5-
expandNode: 'Expand',
5+
expandNode: 'Expand node',
66
};

test/CheckboxTree.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ describe('<CheckboxTree />', () => {
938938
);
939939

940940
const user = userEvent.setup();
941-
await user.click(screen.getByLabelText('Expand'));
941+
await user.click(screen.getByLabelText('Expand node'));
942942

943943
assert.deepEqual(actualExpanded, ['jupiter']);
944944
});
@@ -965,7 +965,7 @@ describe('<CheckboxTree />', () => {
965965
);
966966

967967
const user = userEvent.setup();
968-
await user.click(screen.getByLabelText('Expand'));
968+
await user.click(screen.getByLabelText('Expand node'));
969969

970970
assert.equal(actualNode.value, 'jupiter');
971971
});
@@ -1052,7 +1052,7 @@ describe('<CheckboxTree />', () => {
10521052
assert.deepEqual(getNodeMetadata(clickNode), expectedLeafMetadata);
10531053

10541054
// onExpand
1055-
await user.click(screen.getByLabelText('Collapse'));
1055+
await user.click(screen.getByLabelText('Collapse node'));
10561056
assert.deepEqual(getNodeMetadata(expandNode), expectedParentMetadata);
10571057
});
10581058
});

0 commit comments

Comments
 (0)