Skip to content

Commit a8093f0

Browse files
committed
HV-2057 Sonar: "compareTo" results should not be checked for specific values
1 parent 9c43259 commit a8093f0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/money/MaxValidatorForMonetaryAmount.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public boolean isValid(MonetaryAmount value, ConstraintValidatorContext context)
3535
return true;
3636
}
3737

38-
return value.getNumber().numberValueExact( BigDecimal.class ).compareTo( maxValue ) != 1;
38+
return value.getNumber().numberValueExact( BigDecimal.class ).compareTo( maxValue ) <= 0;
3939
}
4040

4141
}

engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/bv/money/MinValidatorForMonetaryAmount.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public boolean isValid(MonetaryAmount value, ConstraintValidatorContext context)
3535
return true;
3636
}
3737

38-
return value.getNumber().numberValueExact( BigDecimal.class ).compareTo( minValue ) != -1;
38+
return value.getNumber().numberValueExact( BigDecimal.class ).compareTo( minValue ) >= 0;
3939
}
4040

4141
}

0 commit comments

Comments
 (0)