Skip to content

Helm: Invalid ClusterRoleBinding in provisioner #16330

Open
@ryandub

Description

@ryandub

Describe the bug
The logic introduced to the helm chart in #16091 causes an error when using non-namespaced RBAC. This logic appears to intend to switch between RoleBinding and ClusterRoleBinding, but instead switches between RoleBinding and ClusterBinding which is not valid. This leads to an error on chart deployment - ClusterBinding.rbac.authorization.k8s.io "" not found. The logic should be:

{{ if not .Values.rbac.namespaced }}ClusterRole{{ else }}Role{{ end }}Binding

To Reproduce
Steps to reproduce the behavior:

  1. Deploy Loki with Helm chart version >= 6.13.0

Expected behavior
If namespaced RBAC is not enabled, the deployment should properly create a ClusterRoleBinding.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm

Metadata

Metadata

Assignees

Labels

area/helmtype/bugSomehing is not working as expected

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions