Feedback on metrics

Author: grobinson-grafana

pkg/limits/sender.go

@@ -29,8 +29,8 @@ type Sender struct {
 	zone       string
 	logger     log.Logger
 
-	produced       prometheus.Counter
-	producedFailed prometheus.Counter
+	produce       prometheus.Counter
+	produceFailed prometheus.Counter
 }
 
 // NewSender returns a new Sender.
@@ -41,15 +41,15 @@ func NewSender(producer Producer, topic string, partitions int, zone string, log
 		partitions: partitions,
 		zone:       zone,
 		logger:     logger,
-		produced: promauto.With(reg).NewCounter(
+		produce: promauto.With(reg).NewCounter(
 			prometheus.CounterOpts{
-				Name: "loki_ingest_limits_records_produced_total",
-				Help: "The total number of produced records.",
+				Name: "loki_ingest_limits_records_produce_total",
+				Help: "The total number of records produced, including failures.",
 			},
 		),
-		producedFailed: promauto.With(reg).NewCounter(
+		produceFailed: promauto.With(reg).NewCounter(
 			prometheus.CounterOpts{
-				Name: "loki_ingest_limits_records_produced_failed_total",
+				Name: "loki_ingest_limits_records_produce_failed_total",
 				Help: "The total number of failed produced records.",
 			},
 		),
@@ -79,14 +79,14 @@ func (s *Sender) Produce(ctx context.Context, tenant string, metadata *proto.Str
 		Partition: partition,
 		Topic:     s.topic,
 	}
-	s.produced.Inc()
+	s.produce.Inc()
 	s.producer.Produce(context.WithoutCancel(ctx), &r, s.handleProduceErr)
 	return nil
 }
 
 func (s *Sender) handleProduceErr(_ *kgo.Record, err error) {
 	if err != nil {
 		level.Error(s.logger).Log("msg", "failed to produce record", "err", err.Error())
-		s.producedFailed.Inc()
+		s.produceFailed.Inc()
 	}
 }