Skip to content

Commit 7ae5ca5

Browse files
committed
add stdlib to noinilineerr tests
1 parent 36be4e2 commit 7ae5ca5

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

pkg/golinters/noinlineerr/testdata/noinlineerr.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
//golangcitest:args -Enoinlineerr
22
package testdata
33

4+
import "fmt"
5+
46
func doSomething() error {
57
return nil
68
}
@@ -24,9 +26,9 @@ func valid() error {
2426
return err
2527
}
2628

27-
_, err = doSmthMultipleReturn() // ok
29+
ok, err := doSmthMultipleReturn() // ok
2830
if err != nil {
29-
return err
31+
return fmt.Errorf("%b; %w", ok, err)
3032
}
3133
return nil
3234
}
@@ -44,9 +46,8 @@ func invalid() error {
4446
return err
4547
}
4648

47-
if _, err := doSmthMultipleReturn(); err != nil { // want "avoid inline error handling using `if err := ...; err != nil; use plain assignment `err := ..."
48-
_ = false
49-
return err
49+
if ok, err := doSmthMultipleReturn(); err != nil { // want "avoid inline error handling using `if err := ...; err != nil; use plain assignment `err := ..."
50+
return fmt.Errorf("%b; %w", ok, err)
5051
}
5152
return nil
5253
}

0 commit comments

Comments
 (0)