exit with the code 5 if no go files to analyze

Author: jirfag

Gopkg.lock

@@ -18,6 +18,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/printers"
 	"github.com/golangci/golangci-lint/pkg/result"
+	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 )
@@ -249,7 +250,7 @@ func (e *Executor) runAnalysis(ctx context.Context, args []string) (<-chan resul
 
 	lintCtx, err := lint.LoadContext(linters, e.cfg, e.log.Child("load"))
 	if err != nil {
-		return nil, err
+		return nil, errors.Wrap(err, "context loading failed")
 	}
 
 	runner, err := lint.NewRunner(lintCtx.ASTCache, e.cfg, e.log.Child("runner"))
@@ -284,7 +285,7 @@ func (e *Executor) runAndPrint(ctx context.Context, args []string) error {
 
 	issues, err := e.runAnalysis(ctx, args)
 	if err != nil {
-		return err
+		return err // XXX: don't loose type
 	}
 
 	p, err := e.createPrinter()
@@ -345,7 +346,11 @@ func (e *Executor) executeRun(cmd *cobra.Command, args []string) {
 	if err := e.runAndPrint(ctx, args); err != nil {
 		e.log.Errorf("Running error: %s", err)
 		if e.exitCode == exitcodes.Success {
-			e.exitCode = exitcodes.Failure
+			if exitErr, ok := errors.Cause(err).(*exitcodes.ExitError); ok {
+				e.exitCode = exitErr.Code
+			} else {
+				e.exitCode = exitcodes.Failure
+			}
 		}
 	}
 

pkg/commands/run.go

@@ -6,4 +6,21 @@ const (
 	WarningInTest = 2
 	Failure       = 3
 	Timeout       = 4
+	NoGoFiles     = 5
+)
+
+type ExitError struct {
+	Message string
+	Code    int
+}
+
+func (e ExitError) Error() string {
+	return e.Message
+}
+
+var (
+	ErrNoGoFiles = &ExitError{
+		Message: "no go files to analyze",
+		Code:    NoGoFiles,
+	}
 )

pkg/exitcodes/exitcodes.go

@@ -10,6 +10,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/fsutils"
 	"github.com/golangci/golangci-lint/pkg/goutils"
 	"github.com/golangci/golangci-lint/pkg/logutils"
@@ -303,6 +304,10 @@ func LoadContext(linters []linter.Config, cfg *config.Config, log logutils.Log)
 		return nil, err
 	}
 
+	if len(pkgProg.Packages()) == 0 {
+		return nil, exitcodes.ErrNoGoFiles
+	}
+
 	prog, loaderConfig, err := loadWholeAppIfNeeded(linters, cfg, pkgProg, log)
 	if err != nil {
 		return nil, err