Bad OAuth2 OpenID Connect management with invalid URL

[fmarcia]

• Gitea version (or commit ref): 1.12.3
• Git version: 2.28.0
• Operating system: linux amd64
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist: https://gist.github.com/fmarcia/d140d16c5f02318e87497451ececb027

Description

I prepared a new OAuth2 OpenID Connect source with a fake auto-discovery URL and I've got an error 500 after validation but the new source has been saved. I tried to change the fake URL with a more specific one, but still fake. This time, I have got an error specifying the URL is not accessible and the new URL has not been saved.

From there, I could not restard Gitea service (see log where it's specified the URL is not useable) until I removed the faulty source in db.

[techknowlogick]

FWIW oauth management is also available via CLI (https://docs.gitea.io/en-us/command-line/#admin) so if this happens again, then you don't need to fiddle with DB.

[fmarcia]

@techknowlogick thanks to remind me that

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.