Skip to content

Commit d158472

Browse files
authored
Don't return 500 if mirror url contains special chars (#31859)
Fix #31640
1 parent d1426de commit d158472

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

routers/web/repo/setting/setting.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,8 @@ func SettingsPost(ctx *context.Context) {
240240

241241
remoteAddress, err := util.SanitizeURL(form.MirrorAddress)
242242
if err != nil {
243-
ctx.ServerError("SanitizeURL", err)
243+
ctx.Data["Err_MirrorAddress"] = true
244+
handleSettingRemoteAddrError(ctx, err, form)
244245
return
245246
}
246247
pullMirror.RemoteAddress = remoteAddress
@@ -401,7 +402,8 @@ func SettingsPost(ctx *context.Context) {
401402

402403
remoteAddress, err := util.SanitizeURL(form.PushMirrorAddress)
403404
if err != nil {
404-
ctx.ServerError("SanitizeURL", err)
405+
ctx.Data["Err_PushMirrorAddress"] = true
406+
handleSettingRemoteAddrError(ctx, err, form)
405407
return
406408
}
407409

0 commit comments

Comments
 (0)