Skip to content

Commit 81f13d5

Browse files
committed
Reorder ENV for better caching
1 parent c816395 commit 81f13d5

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

Dockerfile

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
# Build stage
22
FROM docker.io/library/node:20-alpine3.18 AS build-frontend
33

4-
ARG GITHUB_REF_NAME
5-
ARG GITHUB_REF_TYPE
6-
ARG NIGHTLY_VERSION
7-
8-
ENV GITHUB_REF_NAME=${GITHUB_REF_NAME:-docker-develop}
9-
ENV GITHUB_REF_TYPE=${GITHUB_REF_TYPE:-branch}
10-
ENV NIGHTLY_VERSION=${NIGHTLY_VERSION}
11-
124
# Build deps
135
RUN apk --no-cache add build-base git \
146
&& rm -rf /var/cache/apk/*
@@ -30,12 +22,6 @@ COPY ./assets ./assets
3022
COPY ./public ./public
3123
COPY ./web_src ./web_src
3224

33-
# Build frontend
34-
RUN make clean-all frontend
35-
36-
# Build stage
37-
FROM docker.io/library/golang:1.21-alpine3.18 AS build-backend
38-
3925
ARG GITHUB_REF_NAME
4026
ARG GITHUB_REF_TYPE
4127
ARG NIGHTLY_VERSION
@@ -44,6 +30,12 @@ ENV GITHUB_REF_NAME=${GITHUB_REF_NAME:-docker-develop}
4430
ENV GITHUB_REF_TYPE=${GITHUB_REF_TYPE:-branch}
4531
ENV NIGHTLY_VERSION=${NIGHTLY_VERSION}
4632

33+
# Build frontend
34+
RUN make clean-all frontend
35+
36+
# Build stage
37+
FROM docker.io/library/golang:1.21-alpine3.18 AS build-backend
38+
4739
ARG GOPROXY
4840
ENV GOPROXY ${GOPROXY:-direct}
4941

@@ -84,6 +76,14 @@ RUN make clean-all
8476
# Copy frontend build artifacts
8577
COPY --from=build-frontend /usr/src/code.gitea.io/gitea/public ./public
8678

79+
ARG GITHUB_REF_NAME
80+
ARG GITHUB_REF_TYPE
81+
ARG NIGHTLY_VERSION
82+
83+
ENV GITHUB_REF_NAME=${GITHUB_REF_NAME:-docker-develop}
84+
ENV GITHUB_REF_TYPE=${GITHUB_REF_TYPE:-branch}
85+
ENV NIGHTLY_VERSION=${NIGHTLY_VERSION}
86+
8787
# Build backend
8888
RUN make backend
8989

0 commit comments

Comments
 (0)