Added test and moved implementation_scope text

Author: rak3-sh

cpp/autosar/test/rules/M0-1-3/test.cpp

@@ -47,6 +47,7 @@ void test_side_effect_init() {
 }
 
 #include <cstdio>
+#include <array>
 template <int t>
 class CharBuffer
 {
@@ -55,13 +56,31 @@ class CharBuffer
   CharBuffer():member{0}{}
 };
 
-int foo()
+int test_constexpr_in_template_inst()
 {
-  constexpr int line_length = 1024U;
+  constexpr int line_length = 1024U; // COMPLIANT - used in template inst.
+                                     // of buffer.
   CharBuffer<line_length> buffer{};
-  constexpr std::size_t max_stack_size_usage = 64 * 1024;
-  static_assert(
-      (sizeof(buffer) + sizeof(line_length)) <= max_stack_size_usage,
-        "assert");
   return buffer.member[0];
 }
+
+enum DataType : unsigned char {
+    int8,
+    int16,
+};
+
+template <typename... Types>
+int test_constexpr_in_static_assert()
+{
+  const std::array <DataType, sizeof...(Types)> lldts {int8};
+  const std::array <DataType, sizeof...(Types)> llams {int16};
+  constexpr std::size_t mssu = 64 * 1024; // COMPLIANT - used in static assert.
+  static_assert((sizeof(lldts) + sizeof(llams)) <= mssu, "assert");
+  return 0;
+}
+
+int baz()
+{
+  test_constexpr_in_static_assert<int>();
+  return 0;
+}

rule_packages/cpp/DeadCode.json

@@ -238,7 +238,10 @@
           "tags": [
             "readability",
             "maintainability"
-          ]
+          ],
+          "implementation_scope": {
+            "description": "In limited cases, this query can raise false-positives for variables that are defined as constexpr and used in an expression to instantiate a template."
+          }
         },
         {
           "description": "Unused variables complicate the program and can indicate a possible mistake on the part of the programmer.",
@@ -344,4 +347,4 @@
       "title": "There shall be no dead code."
     }
   }
-}
+}

rule_packages/cpp/Templates.json

@@ -190,33 +190,6 @@
           }
       ],
       "title": "In a class template with a dependent base, any name that may be found in that dependent base shall be referred to using a qualified-id or this->."
-    },
-    "M0-1-3": {
-      "properties": {
-        "allocated-target": [
-          "implementation"
-        ],
-        "enforcement": "automated",
-        "obligation": "required"
-      },
-      "queries": [
-        {
-          "description": "Unused variables complicate the program and can indicate a possible mistake on the part of the programmer.",
-          "kind": "problem",
-          "name": "A project shall not contain unused local variables",
-          "precision": "very-high",
-          "severity": "warning",
-          "short_name": "UnusedLocalVariable",
-          "tags": [
-            "maintainability",
-            "readability"
-          ],
-          "implementation_scope": {
-            "description": "In limited cases, this query can raise false-positives for variables that are defined as constexpr and used in an expression to instantiate a template."
-          }
-        }
-      ],
-      "title": "A project shall not contain unused local variables."
     }
   }
 }