Report ATOMIC_VAR_INIT for all C versions.

Author: MichaelRFairhurst

c/misra/src/rules/RULE-1-5/UseOfObsoleteMacroAtomicVarInit.ql

@@ -16,11 +16,9 @@
 import cpp
 import codingstandards.c.misra
 
-from MacroInvocation invoke, Compilation c, string flag
+from MacroInvocation invoke
 where
   not isExcluded(invoke, Language4Package::useOfObsoleteMacroAtomicVarInitQuery()) and
-  invoke.getMacroName() = "ATOMIC_VAR_INIT" and
-  flag = c.getAnArgument() and
-  flag.regexpMatch("-std=c1[78]")
+  invoke.getMacroName() = "ATOMIC_VAR_INIT"
 select invoke,
-  "Usage of macro ATOMIC_VAR_INIT() is considered obsolete for c version '" + flag + "'."
+  "Usage of macro ATOMIC_VAR_INIT() is declared obscelescent in C18, and discouraged in earlier C versions."

c/misra/test/rules/RULE-1-5/CallToReallocWithSizeZero.expected

@@ -1 +1 @@
-| test.c:13:14:13:14 | 0 | Calling realloc with size zero results in implementation-defined behavior. |
+| test.c:11:14:11:14 | 0 | Calling realloc with size zero results in implementation-defined behavior. |

c/misra/test/rules/RULE-1-5/FunctionTypesNotInPrototypeForm.expected

@@ -1,2 +1,2 @@
-| test.c:40:6:40:7 | f2 | Function f2 does not specify void for no parameters present. |
-| test.c:44:5:44:6 | f5 | Function f5 declares parameter in unsupported declaration list. |
+| test.c:38:6:38:7 | f2 | Function f2 does not specify void for no parameters present. |
+| test.c:42:5:42:6 | f5 | Function f5 declares parameter in unsupported declaration list. |

c/misra/test/rules/RULE-1-5/InvalidDefineOrUndefOfStdBoolMacro.expected

@@ -1,6 +1,6 @@
-| test.c:23:1:23:14 | #define true 3 | Invalid define of boolean standard macro 'true'. |
-| test.c:24:1:24:15 | #define false 3 | Invalid define of boolean standard macro 'false'. |
-| test.c:25:1:25:18 | #define bool int * | Invalid define of boolean standard macro 'bool'. |
-| test.c:26:1:26:11 | #undef true | Invalid undefine of boolean standard macro 'true'. |
-| test.c:27:1:27:12 | #undef false | Invalid undefine of boolean standard macro 'false'. |
-| test.c:28:1:28:11 | #undef bool | Invalid undefine of boolean standard macro 'bool'. |
+| test.c:21:1:21:14 | #define true 3 | Invalid define of boolean standard macro 'true'. |
+| test.c:22:1:22:15 | #define false 3 | Invalid define of boolean standard macro 'false'. |
+| test.c:23:1:23:18 | #define bool int * | Invalid define of boolean standard macro 'bool'. |
+| test.c:24:1:24:11 | #undef true | Invalid undefine of boolean standard macro 'true'. |
+| test.c:25:1:25:12 | #undef false | Invalid undefine of boolean standard macro 'false'. |
+| test.c:26:1:26:11 | #undef bool | Invalid undefine of boolean standard macro 'bool'. |

c/misra/test/rules/RULE-1-5/MemoryAllocDeallocFunctionsOfStdlibhUsed.expected

@@ -1,3 +1,3 @@
-| test.c:10:12:10:17 | call to malloc | Use of banned dynamic memory allocation. |
-| test.c:13:3:13:9 | call to realloc | Use of banned dynamic memory allocation. |
-| test.c:16:3:16:9 | call to realloc | Use of banned dynamic memory allocation. |
+| test.c:8:12:8:17 | call to malloc | Use of banned dynamic memory allocation. |
+| test.c:11:3:11:9 | call to realloc | Use of banned dynamic memory allocation. |
+| test.c:14:3:14:9 | call to realloc | Use of banned dynamic memory allocation. |

c/misra/test/rules/RULE-1-5/MissingStaticSpecifierObjectRedeclarationC.expected

@@ -1 +1 @@
-| test.c:37:12:37:13 | declaration of g5 | The redeclaration of $@ with internal linkage misses the static specifier. | test.c:36:12:36:13 | definition of g5 | g5 |
+| test.c:35:12:35:13 | declaration of g5 | The redeclaration of $@ with internal linkage misses the static specifier. | test.c:34:12:34:13 | definition of g5 | g5 |

c/misra/test/rules/RULE-1-5/StandardLibraryInputoutputFunctionsUsed.expected

@@ -1,3 +1,3 @@
-| test.c:55:3:55:8 | call to ungetc | Call to banned function ungetc. |
-| test.c:58:3:58:7 | call to fread | Call to banned function fread. |
-| test.c:60:3:60:8 | call to ungetc | Call to banned function ungetc. |
+| test.c:53:3:53:8 | call to ungetc | Call to banned function ungetc. |
+| test.c:56:3:56:7 | call to fread | Call to banned function fread. |
+| test.c:58:3:58:8 | call to ungetc | Call to banned function ungetc. |

c/misra/test/rules/RULE-1-5/UseOfObsoleteMacroAtomicVarInit.expected

@@ -1 +1 @@
-| test.c:30:18:30:36 | ATOMIC_VAR_INIT(value) | Usage of macro ATOMIC_VAR_INIT() is considered obsolete for c version '-std=c17'. |
+| test.c:28:18:28:36 | ATOMIC_VAR_INIT(value) | Usage of macro ATOMIC_VAR_INIT() is declared obscelescent in C18, and discouraged in earlier C versions. |

c/misra/test/rules/RULE-1-5/options

@@ -1,5 +1,3 @@
-// Compiled with -std=c17
-
 #include "stdatomic.h"
 #include "stdbool.h"
 #include "stdio.h"