Declarations6: add RULE-8-10

Author: knewbury01

c/misra/src/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.ql

@@ -0,0 +1,24 @@
+/**
+ * @id c/misra/inline-function-not-declared-static-storage
+ * @name RULE-8-10: An inline function shall be declared with the static storage class
+ * @description Declaring an inline function with external linkage can lead to undefined or
+ *              incorrect program behaviour.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-8-10
+ *       correctness
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.Identifiers
+
+from FunctionDeclarationEntry f
+where
+  not isExcluded(f, Declarations6Package::inlineFunctionNotDeclaredStaticStorageQuery()) and
+  f.getFunction() instanceof InterestingIdentifiers and
+  f.getFunction().isInline() and
+  not f.hasSpecifier("static")
+select f, "Inline function not explicitly declared static."

c/misra/test/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.expected

@@ -0,0 +1,3 @@
+| test.c:2:20:2:21 | declaration of f1 | Inline function not explicitly declared static. |
+| test.c:3:13:3:14 | declaration of f2 | Inline function not explicitly declared static. |
+| test.c:4:20:4:20 | declaration of f | Inline function not explicitly declared static. |

c/misra/test/rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.qlref

@@ -0,0 +1 @@
+rules/RULE-8-10/InlineFunctionNotDeclaredStaticStorage.ql

c/misra/test/rules/RULE-8-10/test.c

@@ -0,0 +1,5 @@
+static inline void f();  // COMPLIANT
+extern inline void f1(); // NON_COMPLIANT
+inline void f2();        // NON_COMPLIANT
+extern inline void f(); // NON_COMPLIANT -while this will be internal linkage it
+                        // is less clear than explicitly specifying static

cpp/common/src/codingstandards/cpp/exclusions/c/Declarations6.qll

@@ -7,6 +7,7 @@ newtype Declarations6Query =
   TFunctionDeclaredImplicitlyQuery() or
   TIdentifiersWithExternalLinkageNotUniqueQuery() or
   TIdentifiersWithInternalLinkageNotUniqueQuery() or
+  TInlineFunctionNotDeclaredStaticStorageQuery() or
   TArrayExternalLinkageSizeExplicitlySpecifiedQuery() or
   TShouldNotBeDefinedWithExternalLinkageQuery()
 
@@ -38,6 +39,15 @@ predicate isDeclarations6QueryMetadata(Query query, string queryId, string ruleI
   ruleId = "RULE-5-9" and
   category = "advisory"
   or
+  query =
+    // `Query` instance for the `inlineFunctionNotDeclaredStaticStorage` query
+    Declarations6Package::inlineFunctionNotDeclaredStaticStorageQuery() and
+  queryId =
+    // `@id` for the `inlineFunctionNotDeclaredStaticStorage` query
+    "c/misra/inline-function-not-declared-static-storage" and
+  ruleId = "RULE-8-10" and
+  category = "required"
+  or
   query =
     // `Query` instance for the `arrayExternalLinkageSizeExplicitlySpecified` query
     Declarations6Package::arrayExternalLinkageSizeExplicitlySpecifiedQuery() and
@@ -79,6 +89,13 @@ module Declarations6Package {
       TQueryC(TDeclarations6PackageQuery(TIdentifiersWithInternalLinkageNotUniqueQuery()))
   }
 
+  Query inlineFunctionNotDeclaredStaticStorageQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `inlineFunctionNotDeclaredStaticStorage` query
+      TQueryC(TDeclarations6PackageQuery(TInlineFunctionNotDeclaredStaticStorageQuery()))
+  }
+
   Query arrayExternalLinkageSizeExplicitlySpecifiedQuery() {
     //autogenerate `Query` type
     result =

rule_packages/c/Declarations6.json

@@ -60,6 +60,25 @@
       ],
       "title": "Identifiers that define objects or functions with internal linkage should be unique"
     },
+    "RULE-8-10": {
+      "properties": {
+        "obligation": "required"
+      },
+      "queries": [
+        {
+          "description": "Declaring an inline function with external linkage can lead to undefined or incorrect program behaviour.",
+          "kind": "problem",
+          "name": "An inline function shall be declared with the static storage class",
+          "precision": "very-high",
+          "severity": "error",
+          "short_name": "InlineFunctionNotDeclaredStaticStorage",
+          "tags": [
+            "correctness"
+          ]
+        }
+      ],
+      "title": "An inline function shall be declared with the static storage class"
+    },
     "RULE-8-11": {
       "properties": {
         "obligation": "advisory"

rules.csv

@@ -655,7 +655,7 @@ c,MISRA-C-2012,RULE-8-6,Yes,Required,,,An identifier with external linkage shall
 c,MISRA-C-2012,RULE-8-7,Yes,Advisory,,,Functions and objects should not be defined with external linkage if they are referenced in only one translation unit,,Declarations6,Medium,
 c,MISRA-C-2012,RULE-8-8,Yes,Required,,,The static storage class specifier shall be used in all declarations of objects and functions that have internal linkage,M3-3-2,Declarations,Medium,
 c,MISRA-C-2012,RULE-8-9,Yes,Advisory,,,An object should be defined at block scope if its identifier only appears in a single function,M3-4-1,Declarations,Medium,
-c,MISRA-C-2012,RULE-8-10,Yes,Required,,,An inline function shall be declared with the static storage class,,Declarations,Medium,
+c,MISRA-C-2012,RULE-8-10,Yes,Required,,,An inline function shall be declared with the static storage class,,Declarations6,Medium,
 c,MISRA-C-2012,RULE-8-11,Yes,Advisory,,,"When an array with external linkage is declared, its size should be explicitly specified",,Declarations6,Medium,
 c,MISRA-C-2012,RULE-8-12,Yes,Required,,,"Within an enumerator list, the value of an implicitly-specified enumeration constant shall be unique",,Declarations,Medium,
 c,MISRA-C-2012,RULE-8-13,Yes,Advisory,,,A pointer should point to a const-qualified type whenever possible,,Pointers1,Medium,