Skip to content

Commit 15719e0

Browse files
authored
always download the right webdriver version (#5471)
1 parent a4e770e commit 15719e0

File tree

3 files changed

+27
-13
lines changed

3 files changed

+27
-13
lines changed

.github/workflows/test-all.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,26 @@
11
name: Test All Packages
22

33
on: push
4+
env:
5+
# make chromedriver detect installed Chrome version and download the corresponding driver
6+
DETECT_CHROMEDRIVER_VERSION: true
47

58
jobs:
69
test:
710
name: Node.js and Browser (Chrome) Tests
811
runs-on: ubuntu-latest
912

1013
steps:
14+
# install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
15+
- name: install Chrome stable
16+
run: |
17+
sudo apt-get update
18+
sudo apt-get install google-chrome-stable
1119
- uses: actions/checkout@v2
1220
- name: Set up Node (14)
1321
uses: actions/setup-node@v2
1422
with:
1523
node-version: 14.x
16-
- name: install Chrome stable
17-
run: |
18-
sudo apt-get update
19-
sudo apt-get install google-chrome-stable
2024
- name: Bump Node memory limit
2125
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
2226
- name: Test setup and yarn install

.github/workflows/test-changed-auth.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@ name: Test Auth
22

33
on: pull_request
44

5+
env:
6+
# make chromedriver detect installed Chrome version and download the corresponding driver
7+
DETECT_CHROMEDRIVER_VERSION: true
8+
59
jobs:
610
test:
711
name: Test Auth If Changed
812
runs-on: ubuntu-latest
913

1014
steps:
15+
# install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
16+
- name: install Chrome stable
17+
run: |
18+
sudo apt-get update
19+
sudo apt-get install google-chrome-stable
1120
- name: Checkout Repo
1221
uses: actions/checkout@master
1322
with:
@@ -17,17 +26,13 @@ jobs:
1726
uses: actions/setup-node@v2
1827
with:
1928
node-version: 14.x
20-
- name: install Chrome stable
21-
run: |
22-
sudo apt-get update
23-
sudo apt-get install google-chrome-stable
2429
- name: Bump Node memory limit
2530
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
2631
- name: Test setup and yarn install
2732
run: |
2833
cp config/ci.config.json config/project.json
2934
yarn
3035
- name: build
31-
run: yarn build:changed auth --buildAll
36+
run: yarn build:changed auth
3237
- name: Run tests on changed packages
3338
run: xvfb-run yarn test:changed auth

.github/workflows/test-changed-fcm-integration.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@ name: Test FCM integration
22

33
on: pull_request
44

5+
env:
6+
# make chromedriver detect installed Chrome version and download the corresponding driver
7+
DETECT_CHROMEDRIVER_VERSION: true
8+
59
jobs:
610
test:
711
name: Test FCM integration If Changed
812
runs-on: ubuntu-latest
913

1014
steps:
15+
# install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
16+
- name: install Chrome stable
17+
run: |
18+
sudo apt-get update
19+
sudo apt-get install google-chrome-stable
1120
- name: Checkout Repo
1221
uses: actions/checkout@master
1322
with:
@@ -17,10 +26,6 @@ jobs:
1726
uses: actions/setup-node@v2
1827
with:
1928
node-version: 14.x
20-
- name: install Chrome stable
21-
run: |
22-
sudo apt-get update
23-
sudo apt-get install google-chrome-stable
2429
- name: Bump Node memory limit
2530
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
2631
- name: Test setup and yarn install

0 commit comments

Comments
 (0)