🔧 fix: #1177 cookie does not sign when an error is thrown

Author: SaltyAom

CHANGELOG.md

@@ -36,6 +36,7 @@ Improvement:
 - support resolve macro on ws
 - [#1146](https://github.com/elysiajs/elysia/pull/1146) add support to return web API's File from handler
 - [#1165](https://github.com/elysiajs/elysia/pull/1165) skip non-numeric status codes in response schema validation
+- [#1177](https://github.com/elysiajs/elysia/issues/1177) cookie does not sign when an error is thrown
 
 Bug fix:
 - `Response` returned from `onError` is using octet stream

example/a.ts

@@ -1,18 +1,34 @@
 import { Elysia, t } from '../src'
 
 const app = new Elysia()
-	.macro({
-		a: {
-			resolve: () => ({
-				a: 'a'
+	.onError(({ code, error }) => {
+		console.error('[error]', error)
+		return { error: { code } }
+	})
+	.get(
+		'/session',
+		({ error, cookie: { sessionToken } }) => {
+			const refreshed = !!sessionToken.value
+
+			sessionToken.set({
+				value: Math.random().toString(36).substring(2, 8),
+				maxAge: 1000 * 60 * 60 * 24 * 7
 			})
+
+			if (refreshed) throw error('Unauthorized')
+
+			return sessionToken.value
+		},
+		{
+			cookie: t.Cookie(
+				{ sessionToken: t.Optional(t.String()) },
+				{
+					sign: ['sessionToken'],
+					secrets: 'my-secret'
+				}
+			)
 		}
-	})
-	.get('/a', ({ a }) => {}, {
-		a: true,
-		beforeHandle: ({ query }) => {}
-	})
-	.ws('/', {
-		a: true,
-		message({ data: { a } }) {}
-	})
+	)
+	.listen(3000)
+
+console.log(app.routes[0].compile().toString())

src/compose.ts

@@ -1873,6 +1873,8 @@ export const composeHandler = ({
 		`const set=c.set\n` +
 		`if(!set.status||set.status<300)set.status=error?.status||500\n`
 
+	if (hasCookie) fnLiteral += encodeCookie()
+
 	if (hasTrace && hooks.trace)
 		for (let i = 0; i < hooks.trace.length; i++)
 			// There's a case where the error is thrown before any trace is called