Skip to content

Commit 0b58be6

Browse files
committed
some documenting
1 parent 48049e8 commit 0b58be6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/integration/test_dropbox.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def _value_from_env_or_die(env_name):
7070
_TRUSTED_CERTS_FILE = os.path.join(os.path.dirname(__file__), "trusted-certs.crt")
7171
_EXPIRED_CERTS_FILE = os.path.join(os.path.dirname(__file__), "expired-certs.crt")
7272

73+
# enables testing both with and without a manually-provided CA bundle
7374
@pytest.fixture(params=[None, _TRUSTED_CERTS_FILE], ids=["no-pinning", "pinning"])
7475
def dbx_session(request):
7576
return create_session(ca_certs=request.param)
@@ -325,6 +326,7 @@ def test_bad_auth(dbx_session):
325326
assert cm.value.error.is_invalid_access_token()
326327

327328
def test_bad_pins():
329+
# sanity-check: if we're pinning using expired pins, we should fail w/ an SSL error
328330
_dbx = Dropbox("dummy_token", ca_certs=_EXPIRED_CERTS_FILE)
329331
with pytest.raises(SSLError,) as cm:
330332
_dbx.files_list_folder('')

0 commit comments

Comments
 (0)