Skip to content

Commit a9f725f

Browse files
committed
migrated ccloud commands to confluent cli v2.x
1 parent 61c1dcd commit a9f725f

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

src/main/java/com/devshawn/kafka/gitops/StateManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,8 @@ private void validateTopics(DesiredStateFile desiredStateFile) {
322322
}
323323

324324
private boolean isConfluentCloudEnabled(DesiredStateFile desiredStateFile) {
325-
if (desiredStateFile.getSettings().isPresent() && desiredStateFile.getSettings().get().getCcloud().isPresent()) {
326-
return desiredStateFile.getSettings().get().getCcloud().get().isEnabled();
325+
if (desiredStateFile.getSettings().isPresent() && desiredStateFile.getSettings().get().getConfluent().isPresent()) {
326+
return desiredStateFile.getSettings().get().getConfluent().get().isEnabled();
327327
}
328328
return false;
329329
}

src/main/java/com/devshawn/kafka/gitops/domain/state/settings/Settings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
@JsonDeserialize(builder = Settings.Builder.class)
1010
public interface Settings {
1111

12-
Optional<SettingsCCloud> getCcloud();
12+
Optional<SettingsConfluent> getConfluent();
1313

1414
Optional<SettingsTopics> getTopics();
1515

src/main/java/com/devshawn/kafka/gitops/domain/state/settings/SettingsCCloud.java renamed to src/main/java/com/devshawn/kafka/gitops/domain/state/settings/SettingsConfluent.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
import org.inferred.freebuilder.FreeBuilder;
55

66
@FreeBuilder
7-
@JsonDeserialize(builder = SettingsCCloud.Builder.class)
8-
public interface SettingsCCloud {
7+
@JsonDeserialize(builder = SettingsConfluent.Builder.class)
8+
public interface SettingsConfluent {
99

1010
boolean isEnabled();
1111

12-
class Builder extends SettingsCCloud_Builder {
12+
class Builder extends SettingsConfluent_Builder {
1313
}
1414
}

src/main/java/com/devshawn/kafka/gitops/service/ConfluentCloudService.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@ public class ConfluentCloudService {
1414
private static org.slf4j.Logger log = LoggerFactory.getLogger(ConfluentCloudService.class);
1515

1616
private final ObjectMapper objectMapper;
17+
private static final String confluentExecutable;
1718
private static final String ccloudExecutable;
1819

1920
public ConfluentCloudService(ObjectMapper objectMapper) {
2021
this.objectMapper = objectMapper;
2122
}
2223

2324
public List<ServiceAccount> getServiceAccounts() {
24-
log.info("Fetching service account list from Confluent Cloud via ccloud tool.");
25+
log.info("Fetching service account list from Confluent Cloud via confluent tool.");
2526
try {
2627
String result = execCmd(new String[]{ccloudExecutable, "service-account", "list", "-o", "json"});
2728
return objectMapper.readValue(result, new TypeReference<List<ServiceAccount>>() {
@@ -33,11 +34,11 @@ public List<ServiceAccount> getServiceAccounts() {
3334
}
3435

3536
public ServiceAccount createServiceAccount(String name, boolean isUser) {
36-
log.info("Creating service account {} in Confluent Cloud via ccloud tool.", name);
37+
log.info("Creating service account {} in Confluent Cloud via confluent tool.", name);
3738
try {
3839
String serviceName = isUser ? String.format("user-%s", name) : name;
3940
String description = isUser ? String.format("User: %s", name) : String.format("Service account: %s", name);
40-
String result = execCmd(new String[]{ccloudExecutable, "service-account", "create", serviceName, "--description", description, "-o", "json"});
41+
String result = execCmd(new String[]{confluentExecutable, "iam", "service-account", "create", serviceName, "--description", description, "-o", "json"});
4142
return objectMapper.readValue(result, ServiceAccount.class);
4243
} catch (IOException ex) {
4344
throw new ConfluentCloudException(String.format("There was an error creating Confluent Cloud service account: %s.", name));
@@ -50,7 +51,9 @@ public static String execCmd(String[] cmd) throws java.io.IOException {
5051
}
5152

5253
static {
54+
confluentExecutable = System.getenv("CONFLUENT_EXECUTABLE_PATH") != null ? System.getenv("CONFLUENT_EXECUTABLE_PATH") : "confluent";
55+
log.info("Using confluent executable at: {}", confluentExecutable);
5356
ccloudExecutable = System.getenv("CCLOUD_EXECUTABLE_PATH") != null ? System.getenv("CCLOUD_EXECUTABLE_PATH") : "ccloud";
54-
log.info("Using ccloud executable at: {}", ccloudExecutable);
57+
log.info("Using ccloud executable at: {}", confluentExecutable);
5558
}
5659
}

0 commit comments

Comments
 (0)