Skip to content

Minor updates to LSQL and LDMS modules. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iojior
Copy link

@iojior iojior commented May 15, 2025

Updated the git hash to use in LSQL module so the chalise app is not tied to the us-west-2 region.
Minor alterations to the LDMS module instructions to make it easier to follow.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Minor alterations to the LDMS workshop instructions to make it easier to follow.
Copy link
Contributor

@tebanieo tebanieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks For the update, I have requested one modification, and provided one NIT.

Thanks!

@@ -47,7 +47,8 @@ cd workshops/relational-migration
4. Next, run this to install three components: Boto3 (AWS SDK for Python), Chalice, and the MySQL connector for Python.

```bash
sudo pip3 install chalice mysql-connector-python
pip3 install chalice mysql-connector-python
export PATH="/home/ubuntu/.local/bin:$PATH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to

PATH="~/.local/bin:$PATH"

This will ensure portability across different distros/images.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update applied. Thanks.

@@ -31,7 +31,8 @@ To explore the dataset, follow the instructions below to log in to the EC2 serve
6. You can see all the 6 files copied from the IMDB dataset to the local EC2 directory.
![Final Deployment Architecture](/static/images/migration12.jpg)
7. Feel free to explore the files.
8. Go to AWS CloudFormation [Stacks](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks?filteringStatus=active&filteringText=&viewNested=true&hideStacks=false) and click on the stack you created earlier. Go to the Parameters tab and copy the username and password listed next to "DbMasterUsername" and "DbMasterPassword".
8. If you are completing this workshop at an AWS hosted event, go to [AWS CloudFormation Console](https://console.aws.amazon.com/cloudformation/home#/stacks?filteringStatus=active&filteringText=&viewNested=true&hideStacks=false) and select the stack named **ddb**. Go to the **Parameters** tab and copy the username and password listed next to **DbMasterUsername** and **DbMasterPassword**.
::alert[_If you are completing this workshop in your AWS account copy the **DbMasterUsername** and **DbMasterPassword** from the CloudFormation stack used to configure the MySQL environment._]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Add spaces in between the warnings for better readibility.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update applied. Thanks.

Copy link
Contributor

@switch180 switch180 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on merging this until Aman syncs his changes to the relational lab. No action needed on your part, but please hold off on merge.

@@ -5,23 +5,23 @@ date: 2021-04-25T07:33:04-05:00
weight: 25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold off on merging until Aman has a chance to sync his changes to the labs. He did a direct commit on the internal version, and these changes might conflict on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants