Remove the internal tag from Core classes used in other packages (#1486)

stof · web-flow · commit 6ca369fb256b · 2023-07-01T17:53:24.000+02:00
diff --git a/src/Core/src/AwsError/AwsError.php b/src/Core/src/AwsError/AwsError.php
@@ -2,9 +2,6 @@
 
 namespace AsyncAws\Core\AwsError;
 
-/**
- * @internal
- */
 final class AwsError
 {
     /**
diff --git a/src/Core/src/AwsError/AwsErrorFactoryFromResponseTrait.php b/src/Core/src/AwsError/AwsErrorFactoryFromResponseTrait.php
@@ -4,9 +4,6 @@
 
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
-/**
- * @internal
- */
 trait AwsErrorFactoryFromResponseTrait
 {
     public function createFromResponse(ResponseInterface $response): AwsError
diff --git a/src/Core/src/AwsError/AwsErrorFactoryInterface.php b/src/Core/src/AwsError/AwsErrorFactoryInterface.php
@@ -4,9 +4,6 @@
 
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
-/**
- * @internal
- */
 interface AwsErrorFactoryInterface
 {
     public function createFromResponse(ResponseInterface $response): AwsError;
diff --git a/src/Core/src/AwsError/JsonRestAwsErrorFactory.php b/src/Core/src/AwsError/JsonRestAwsErrorFactory.php
@@ -5,10 +5,7 @@
 use AsyncAws\Core\Exception\UnexpectedValue;
 use AsyncAws\Core\Exception\UnparsableResponse;
 
-/**
- * @internal
- */
-class JsonRestAwsErrorFactory implements AwsErrorFactoryInterface
+final class JsonRestAwsErrorFactory implements AwsErrorFactoryInterface
 {
     use AwsErrorFactoryFromResponseTrait;
 
diff --git a/src/Core/src/AwsError/JsonRpcAwsErrorFactory.php b/src/Core/src/AwsError/JsonRpcAwsErrorFactory.php
@@ -5,10 +5,7 @@
 use AsyncAws\Core\Exception\UnexpectedValue;
 use AsyncAws\Core\Exception\UnparsableResponse;
 
-/**
- * @internal
- */
-class JsonRpcAwsErrorFactory implements AwsErrorFactoryInterface
+final class JsonRpcAwsErrorFactory implements AwsErrorFactoryInterface
 {
     use AwsErrorFactoryFromResponseTrait;
 
diff --git a/src/Core/src/AwsError/XmlAwsErrorFactory.php b/src/Core/src/AwsError/XmlAwsErrorFactory.php
@@ -6,10 +6,7 @@
 use AsyncAws\Core\Exception\UnexpectedValue;
 use AsyncAws\Core\Exception\UnparsableResponse;
 
-/**
- * @internal
- */
-class XmlAwsErrorFactory implements AwsErrorFactoryInterface
+final class XmlAwsErrorFactory implements AwsErrorFactoryInterface
 {
     use AwsErrorFactoryFromResponseTrait;
 
diff --git a/src/Core/src/Input.php b/src/Core/src/Input.php
@@ -6,8 +6,6 @@
  * Representation of a AWS Request.
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
 abstract class Input
 {
diff --git a/src/Core/src/Request.php b/src/Core/src/Request.php
@@ -9,10 +9,8 @@
  * Representation of an HTTP Request.
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
-class Request
+final class Request
 {
     /**
      * @var string
diff --git a/src/Core/src/RequestContext.php b/src/Core/src/RequestContext.php
@@ -9,10 +9,8 @@
  * Contains contextual information alongside a request.
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
-class RequestContext
+final class RequestContext
 {
     public const AVAILABLE_OPTIONS = [
         'region' => true,
diff --git a/src/Core/src/Response.php b/src/Core/src/Response.php
@@ -31,10 +31,8 @@
  * The response provides a facade to manipulate HttpResponses.
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
-class Response
+final class Response
 {
     /**
      * @var ResponseInterface
diff --git a/src/Core/src/Signer/SigningContext.php b/src/Core/src/Signer/SigningContext.php
@@ -5,11 +5,9 @@
 use AsyncAws\Core\Request;
 
 /**
- * @internal
- *
  * @author Jérémy Derussé <jeremy@derusse.com>
  */
-class SigningContext
+final class SigningContext
 {
     /**
      * @var Request
diff --git a/src/Core/src/Stream/FixedSizeStream.php b/src/Core/src/Stream/FixedSizeStream.php
@@ -8,8 +8,6 @@
  * A Stream decorator that return Chunk with the same exact size.
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
 final class FixedSizeStream implements RequestStream
 {
diff --git a/src/Core/src/Stream/IterableStream.php b/src/Core/src/Stream/IterableStream.php
@@ -8,8 +8,6 @@
  * Convert an iterator into a Stream.
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
 final class IterableStream implements ReadOnceResultStream, RequestStream
 {
diff --git a/src/Core/src/Stream/ReadOnceResultStream.php b/src/Core/src/Stream/ReadOnceResultStream.php
@@ -6,8 +6,6 @@
 
 /**
  * Marker for ResultStream that can be read only once.
- *
- * @internal
  */
 interface ReadOnceResultStream
 {
diff --git a/src/Core/src/Stream/RequestStream.php b/src/Core/src/Stream/RequestStream.php
@@ -7,8 +7,6 @@
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
  *
- * @internal
- *
  * @extends \IteratorAggregate<string>
  */
 interface RequestStream extends \IteratorAggregate
diff --git a/src/Core/src/Stream/RewindableStream.php b/src/Core/src/Stream/RewindableStream.php
@@ -12,8 +12,6 @@
  * - hash
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
- *
- * @internal
  */
 final class RewindableStream implements RequestStream
 {

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,6 @@`
`2`	`2`
`3`	`3`	`namespace AsyncAws\Core\AwsError;`
`4`	`4`
`5`		`-/**`
`6`		`- * @internal`
`7`		`- */`
`8`	`5`	`final class AwsError`
`9`	`6`	`{`
`10`	`7`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -4,9 +4,6 @@`
`4`	`4`
`5`	`5`	`use Symfony\Contracts\HttpClient\ResponseInterface;`
`6`	`6`
`7`		`-/**`
`8`		`- * @internal`
`9`		`- */`
`10`	`7`	`trait AwsErrorFactoryFromResponseTrait`
`11`	`8`	`{`
`12`	`9`	`public function createFromResponse(ResponseInterface $response): AwsError`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@`
`6`	`6`	`* Representation of a AWS Request.`
`7`	`7`	`*`
`8`	`8`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`9`		`- *`
`10`		`- * @internal`
`11`	`9`	`*/`
`12`	`10`	`abstract class Input`
`13`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,8 @@`
`9`	`9`	`* Representation of an HTTP Request.`
`10`	`10`	`*`
`11`	`11`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`12`		`- *`
`13`		`- * @internal`
`14`	`12`	`*/`
`15`		`-class Request`
	`13`	`+final class Request`
`16`	`14`	`{`
`17`	`15`	`/**`
`18`	`16`	`* @var string`
Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,8 @@`
`9`	`9`	`* Contains contextual information alongside a request.`
`10`	`10`	`*`
`11`	`11`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`12`		`- *`
`13`		`- * @internal`
`14`	`12`	`*/`
`15`		`-class RequestContext`
	`13`	`+final class RequestContext`
`16`	`14`	`{`
`17`	`15`	`public const AVAILABLE_OPTIONS = [`
`18`	`16`	`'region' => true,`
Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,8 @@`
`31`	`31`	`* The response provides a facade to manipulate HttpResponses.`
`32`	`32`	`*`
`33`	`33`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`34`		`- *`
`35`		`- * @internal`
`36`	`34`	`*/`
`37`		`-class Response`
	`35`	`+final class Response`
`38`	`36`	`{`
`39`	`37`	`/**`
`40`	`38`	`* @var ResponseInterface`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`	`* A Stream decorator that return Chunk with the same exact size.`
`9`	`9`	`*`
`10`	`10`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`11`		`- *`
`12`		`- * @internal`
`13`	`11`	`*/`
`14`	`12`	`final class FixedSizeStream implements RequestStream`
`15`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`	`* Convert an iterator into a Stream.`
`9`	`9`	`*`
`10`	`10`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`11`		`- *`
`12`		`- * @internal`
`13`	`11`	`*/`
`14`	`12`	`final class IterableStream implements ReadOnceResultStream, RequestStream`
`15`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@`
`6`	`6`
`7`	`7`	`/**`
`8`	`8`	`* Marker for ResultStream that can be read only once.`
`9`		`- *`
`10`		`- * @internal`
`11`	`9`	`*/`
`12`	`10`	`interface ReadOnceResultStream`
`13`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,6 @@`
`7`	`7`	`*`
`8`	`8`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`9`	`9`	`*`
`10`		`- * @internal`
`11`		`- *`
`12`	`10`	`* @extends \IteratorAggregate<string>`
`13`	`11`	`*/`
`14`	`12`	`interface RequestStream extends \IteratorAggregate`